Guard Image Type Icon from Smooth Scaling

Enabling the smooth scaling for icon produce erroneous result. Resulting
in icon losing its transparency.

Author: ShahzaibIbrahim

bundles/org.eclipse.swt/Eclipse SWT/common/org/eclipse/swt/internal/DPIUtil.java

@@ -292,8 +292,9 @@ private static ImageData autoScaleImageData (Device device, final ImageData imag
 	int height = imageData.height;
 	int scaledWidth = Math.round (width * scaleFactor);
 	int scaledHeight = Math.round (height * scaleFactor);
-	return switch (autoScaleMethod) {
-	case SMOOTH -> {
+	ImageData result;
+	boolean useSmoothScaling = autoScaleMethod == AutoScaleMethod.SMOOTH && imageData.getTransparencyType() != SWT.TRANSPARENCY_MASK;
+	if (useSmoothScaling) {
 		Image original = new Image (device, (ImageDataProvider) zoom -> imageData);
 		/* Create a 24 bit image data with alpha channel */
 		final ImageData resultData = new ImageData (scaledWidth, scaledHeight, 24, new PaletteData (0xFF, 0xFF00, 0xFF0000));
@@ -302,18 +303,21 @@ private static ImageData autoScaleImageData (Device device, final ImageData imag
 		GC gc = new GC (resultImage);
 		gc.setAntialias (SWT.ON);
 		gc.drawImage (original, 0, 0, autoScaleDown (width), autoScaleDown (height),
-				/* E.g. destWidth here is effectively DPIUtil.autoScaleDown (scaledWidth), but avoiding rounding errors.
-				 * Nevertheless, we still have some rounding errors due to the point-based API GC#drawImage(..).
+				/*
+				 * E.g. destWidth here is effectively DPIUtil.autoScaleDown (scaledWidth), but
+				 * avoiding rounding errors. Nevertheless, we still have some rounding errors
+				 * due to the point-based API GC#drawImage(..).
 				 */
 				0, 0, Math.round (autoScaleDown (width * scaleFactor)), Math.round (autoScaleDown (height * scaleFactor)));
 		gc.dispose ();
 		original.dispose ();
-		ImageData result = resultImage.getImageData (getDeviceZoom ());
+		result = resultImage.getImageData (getDeviceZoom ());
 		resultImage.dispose ();
-		yield result;
+	} else {
+		result = imageData.scaledTo (scaledWidth, scaledHeight);
 	}
-	default -> imageData.scaledTo (scaledWidth, scaledHeight);
-	};
+
+	return result;
 }
 
 /**