Skip to content

Commit 6848f0f

Browse files
committed
Browser tests: reduce timeout for instantiation to reasonable value
The timeout for browser instantiation in the browser tests has been increased to avoid flaky tests. However, browser instantiation taking more than 10 seconds (the previous timeout value) is an indicator for something being wrong with the instantiation. There is no reason why instantiation may take that long during test execution but the same issue should never arise in productive use, thus such a case should be captured by tests and, if necessary, be fixed productively. In order to do so, this change reduces the test timeout value again to a more reasonable value. Related to #1676
1 parent d8aaa2f commit 6848f0f

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

tests/org.eclipse.swt.tests/JUnit Tests/org/eclipse/swt/tests/junit/Test_org_eclipse_swt_browser_Browser.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -307,7 +307,7 @@ private int reportOpenedDescriptors() {
307307
}
308308

309309
private Browser createBrowser(Shell s, int flags) {
310-
long maximumBrowserCreationMilliseconds = 90_000;
310+
long maximumBrowserCreationMilliseconds = 10_000;
311311
long createStartTime = System.currentTimeMillis();
312312
Browser b = new Browser(s, flags);
313313
// Wait for asynchronous initialization via getting URL

0 commit comments

Comments
 (0)