Make all API leak-issues errors and fail build on API warnings

Author: HannesWell

binaries/.settings/org.eclipse.pde.api.tools.prefs

@@ -66,11 +66,11 @@ INTERFACE_ELEMENT_TYPE_REMOVED_TYPE_PARAMETER=Error
 INVALID_ANNOTATION=Error
 INVALID_JAVADOC_TAG=Error
 INVALID_REFERENCE_IN_SYSTEM_LIBRARIES=Error
-LEAK_EXTEND=Warning
-LEAK_FIELD_DECL=Warning
-LEAK_IMPLEMENT=Warning
-LEAK_METHOD_PARAM=Warning
-LEAK_METHOD_RETURN_TYPE=Warning
+LEAK_EXTEND=Error
+LEAK_FIELD_DECL=Error
+LEAK_IMPLEMENT=Error
+LEAK_METHOD_PARAM=Error
+LEAK_METHOD_RETURN_TYPE=Error
 METHOD_ELEMENT_TYPE_ADDED_RESTRICTIONS=Error
 METHOD_ELEMENT_TYPE_ADDED_TYPE_PARAMETER=Error
 METHOD_ELEMENT_TYPE_CHANGED_DECREASE_ACCESS=Error
@@ -101,4 +101,4 @@ invalid_since_tag_version=Error
 malformed_since_tag=Error
 missing_since_tag=Error
 report_api_breakage_when_major_version_incremented=Disabled
-report_resolution_errors_api_component=Warning
+report_resolution_errors_api_component=Error

binaries/pom.xml

@@ -49,6 +49,7 @@
 				<version>${tycho.version}</version>
 				<configuration>
 					<addSourceFolders>true</addSourceFolders>
+					<failOnWarning>true</failOnWarning>
 				</configuration>
 			</plugin>
 			<plugin>