Skip to content

Commit 8c5fcdd

Browse files
committed
Exclude TODO tests by default, include them with runtodotests label
In #2757 the idea of using `@Tag("gtk4-todo")` was introduced to tag tests that are known TODO as such. This commit adds todos to the exclude groups list when running such tests. There are not actually any GTK3 x11 todos yet, so this commit on its own may not make sense until GTK4 + wayland tests are enabled in a subsequent commit Apply the label runtodotests to the PR and the todo tests will not be excluded. Part of #2714
1 parent d268884 commit 8c5fcdd

File tree

2 files changed

+9
-0
lines changed

2 files changed

+9
-0
lines changed

.github/workflows/build.yml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,11 @@ on:
2323
type: boolean
2424
required: false
2525
default: false
26+
runtodotests:
27+
description: "Run TODO tagged tests too (one of true, false)"
28+
type: boolean
29+
required: false
30+
default: false
2631

2732
jobs:
2833
build:
@@ -66,6 +71,7 @@ jobs:
6671
--fail-at-end
6772
-DskipNativeTests=false
6873
-DfailIfNoTests=false
74+
${{ (inputs.runtodotests == false && contains(inputs.native, 'linux')) && '-DexcludedGroups=gtk3-todo' || '' }}
6975
clean install
7076
- name: Performance tests
7177
if: ${{ inputs.performance }}

.github/workflows/maven.yml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -46,6 +46,7 @@ jobs:
4646
java: ${{ matrix.java }}
4747
native: gtk.linux.x86_64
4848
performance: ${{ contains(github.event.pull_request.labels.*.name, 'performance') }}
49+
runtodotests: ${{ contains(github.event.pull_request.labels.*.name, 'runtodotests') }}
4950

5051
build-windows:
5152
name: Build (Windows)
@@ -59,6 +60,7 @@ jobs:
5960
java: ${{ matrix.java }}
6061
native: win32.win32.x86_64
6162
performance: ${{ contains(github.event.pull_request.labels.*.name, 'performance') }}
63+
runtodotests: ${{ contains(github.event.pull_request.labels.*.name, 'runtodotests') }}
6264

6365
build-macos:
6466
name: Build (macOS)
@@ -79,3 +81,4 @@ jobs:
7981
java: ${{ matrix.java }}
8082
native: ${{ matrix.native }}
8183
performance: ${{ contains(github.event.pull_request.labels.*.name, 'performance') }}
84+
runtodotests: ${{ contains(github.event.pull_request.labels.*.name, 'runtodotests') }}

0 commit comments

Comments
 (0)