don't modify topIndex in handleTextChanged if control has not the focus

tobias-melcher · akurtakov · commit 9892ab9b2621 · 2024-12-09T17:24:20.000+02:00
diff --git a/bundles/org.eclipse.swt/Eclipse SWT Custom Widgets/common/org/eclipse/swt/custom/StyledText.java b/bundles/org.eclipse.swt/Eclipse SWT Custom Widgets/common/org/eclipse/swt/custom/StyledText.java
@@ -6046,7 +6046,7 @@ void handleTextChanged(TextChangedEvent event) {
 	}
 	int firstLine = content.getLineAtOffset(lastTextChangeStart);
 	resetCache(firstLine, 0);
-	if (!isFixedLineHeight() && topIndex > firstLine) {
+	if (!isFixedLineHeight() && isFocusControl() && topIndex > firstLine) {
 		topIndex = firstLine;
 		if (topIndex < 0) {
 			// TODO: This logging is in place to determine why topIndex is getting set to negative values.

Original file line number	Diff line number	Diff line change
`@@ -6046,7 +6046,7 @@ void handleTextChanged(TextChangedEvent event) {`
`6046`	`6046`	`}`
`6047`	`6047`	`int firstLine = content.getLineAtOffset(lastTextChangeStart);`
`6048`	`6048`	`resetCache(firstLine, 0);`
`6049`		`- if (!isFixedLineHeight() && topIndex > firstLine) {`
	`6049`	`+ if (!isFixedLineHeight() && isFocusControl() && topIndex > firstLine) {`
`6050`	`6050`	`topIndex = firstLine;`
`6051`	`6051`	`if (topIndex < 0) {`
`6052`	`6052`	`// TODO: This logging is in place to determine why topIndex is getting set to negative values.`