Rewrite the algorithm that sets smallIcon/largeIcon in Decorations class

Don't sort, compare and keep the image that is closest to the desired
dimensions, pixel transparency and pixel depth.

The new method "isCloserThan" is based on the (now deleted) "compare"
method and returns true only if "compare" would have returned -1

Reduce visibility of Decorations::setImages

Author: fedejeanne

bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/widgets/Decorations.java

@@ -934,8 +934,8 @@ private static ImageData[] getImageDataAt100(Image[] images) {
 private static int findIndexOfClosest(ImageData[] imageData, int targetWidth, int targetDepth) {
 	int closestIndex = 0;
 	ImageData closestData = imageData[0];
-	for (int i=1; i<imageData.length;i++) {
-		if (isCloserThan(imageData[i],closestData,  targetWidth, targetDepth)) {
+	for (int i = 1; i < imageData.length; i++) {
+		if (isCloserThan(imageData[i], closestData, targetWidth, targetDepth)) {
 			closestIndex = i;
 			closestData = imageData[i];
 		}
@@ -944,32 +944,40 @@ private static int findIndexOfClosest(ImageData[] imageData, int targetWidth, in
 	return closestIndex;
 }
 
-private static boolean isCloserThan (ImageData dataToTest, ImageData referenceData, int targetWidth, int targetDepth) {
-	int diffWidthToTest = Math.abs (dataToTest.width - targetWidth);
-	int diffReferenceWidth = Math.abs (referenceData.width - targetWidth);
+private static boolean isCloserThan(ImageData dataToTest, ImageData referenceData, int targetWidth, int targetDepth) {
+	int diffWidthToTest = Math.abs(dataToTest.width - targetWidth);
+	int diffReferenceWidth = Math.abs(referenceData.width - targetWidth);
 
 	// The closer the width the better
-	if (diffWidthToTest != diffReferenceWidth) return diffWidthToTest < diffReferenceWidth;
+	if (diffWidthToTest != diffReferenceWidth)
+		return diffWidthToTest < diffReferenceWidth;
 
-	int transparencyToTest = dataToTest.getTransparencyType ();
-	int referenceTransparency = referenceData.getTransparencyType ();
+	int transparencyToTest = dataToTest.getTransparencyType();
+	int referenceTransparency = referenceData.getTransparencyType();
 
 	// If they have the same transparency then the bigger the pixel depth (without
 	// surpassing the target depth) the better
 	if (transparencyToTest == referenceTransparency) {
-		if (dataToTest.depth == referenceData.depth) return false;
+		if (dataToTest.depth == referenceData.depth)
+			return false;
 
 		return dataToTest.depth > referenceData.depth && dataToTest.depth <= targetDepth;
 	}
 
 	// If they have different transparency, favor (in this order): the one with
 	// an alpha channel, the one with a mask, the one with a transparency pixel
-	if (transparencyToTest == SWT.TRANSPARENCY_ALPHA) return true;
-	if (referenceTransparency == SWT.TRANSPARENCY_ALPHA) return false;
-	if (transparencyToTest == SWT.TRANSPARENCY_MASK) return true;
-	if (referenceTransparency == SWT.TRANSPARENCY_MASK) return false;
-	if (transparencyToTest == SWT.TRANSPARENCY_PIXEL) return true;
-	if (referenceTransparency == SWT.TRANSPARENCY_PIXEL) return false;
+	if (transparencyToTest == SWT.TRANSPARENCY_ALPHA)
+		return true;
+	if (referenceTransparency == SWT.TRANSPARENCY_ALPHA)
+		return false;
+	if (transparencyToTest == SWT.TRANSPARENCY_MASK)
+		return true;
+	if (referenceTransparency == SWT.TRANSPARENCY_MASK)
+		return false;
+	if (transparencyToTest == SWT.TRANSPARENCY_PIXEL)
+		return true;
+	if (referenceTransparency == SWT.TRANSPARENCY_PIXEL)
+		return false;
 	return false;
 }