StyledText#setLineVerticalIndent: fix overlapping code minings in editor

Ensure problem annotation code minings are rendered below source lines
to prevent visual overlap during vertical scrolling.

Fixes: #2512

Author: tobias-melcher

bundles/org.eclipse.swt/Eclipse SWT Custom Widgets/common/org/eclipse/swt/custom/StyledText.java

@@ -9330,27 +9330,33 @@ public void setLineVerticalIndent(int lineIndex, int verticalLineIndent) {
 		if (verticalScrollbar != null) {
 			verticalScrollbar.setMaximum(verticalScrollbar.getMaximum() + verticalIndentDiff);
 		}
-	} else {
-		resetCache(lineIndex, 1);
-		if((initialTopIndex == 0) && (initialBottomIndex == (content.getLineCount() - 1))) { // not scrollable editor
-		    setCaretLocations();
-			redrawLines(lineIndex, getBottomIndex() - lineIndex + 1, true);
-		} else if (getFirstCaretLine() >= initialTopIndex && getFirstCaretLine() <= initialBottomIndex) { // caret line with caret mustn't move
-			if (getFirstCaretLine() < lineIndex) {
-				redrawLines(lineIndex, getPartialBottomIndex() - lineIndex + 1, true);
-			} else {
-				setTopPixel(initialTopPixel + verticalIndentDiff);
-			}
-		} else { // move as few lines as possible
-			if (lineIndex - getTopIndex() < getBottomIndex() - lineIndex) {
-				setTopPixel(initialTopPixel + verticalIndentDiff);
-			} else {
-				// redraw below
-				redrawLines(lineIndex, getPartialBottomIndex() - lineIndex + 1, true);
-			}
+	}
+	redrawLines(lineIndex, initialTopIndex, initialBottomIndex, initialTopPixel, verticalIndentDiff);
+}
+
+private void redrawLines(int lineIndex, int initialTopIndex, int initialBottomIndex, int initialTopPixel,
+		int verticalIndentDiff) {
+	resetCache(lineIndex, 1);
+	if ((initialTopIndex == 0) && (initialBottomIndex == (content.getLineCount() - 1))) { // not scrollable editor
+		setCaretLocations();
+		redrawLines(lineIndex, getBottomIndex() - lineIndex + 1, true);
+	} else if (getFirstCaretLine() >= initialTopIndex && getFirstCaretLine() <= initialBottomIndex) { // caret line with
+																										// caret mustn't
+																										// move
+		if (getFirstCaretLine() < lineIndex) {
+			redrawLines(lineIndex, getPartialBottomIndex() - lineIndex + 1, true);
+		} else {
+			setTopPixel(initialTopPixel + verticalIndentDiff);
+		}
+	} else { // move as few lines as possible
+		if (lineIndex - getTopIndex() < getBottomIndex() - lineIndex) {
+			setTopPixel(initialTopPixel + verticalIndentDiff);
+		} else {
+			// redraw below
+			redrawLines(lineIndex, getPartialBottomIndex() - lineIndex + 1, true);
 		}
-		setScrollBars(true);
 	}
+	setScrollBars(true);
 }
 
 /**