[GTK4] Migrate to API version 6.0 of webkit and jsc

With the most recent GTK4s the API version is now 6.0 for webkit/jsc
and a lot of [deprecated items have been
removed](https://webkitgtk.org/reference/webkitgtk/2.50.1/migrating-to-webkitgtk-6.0.html#stop-using-deprecated-apis).

This commit brings some of the key implementations to the new webkit
API when using GTK4.

To make it easier to ensure I don't regress anything I had working,
I marked all known tests that need attention for GTK4 with
`@Tag("gtk4-todo")`. This allows running the test suite with exclude
tag of `gtk4-todo` and have a fast and clean run.

This includes a g_critical call when webkitgtk.c cannot dynamically
load a called method. When a method cannot be loaded it fairly silently
fails (normally returns 0). With the g_critical it makes it easier to
spot the problems.

This includes a change to the looping while waiting for a response
from the async script to make timeout more accurate to the default
10s.

TODOs:

- [ ] I plan to split this PR up into a few component parts
- [ ] Cookies
- [ ] Arrays of items (gtk4_convertToJava missing jsc_value_is_object case)
- [ ] a bunch of OpenWindowListener cases (see `@Tag("gtk4-todo")` tests)
- [ ] probably more
- [ ] check which version of API we can use as a reasonable minimum, in
      particular do we need to deal with API version 5 (version 4 was
      the version of the API that aligned with GTK3)
- [ ] Remove `-DexcludedGroups=gtk4-todo` from GHA workflow

Fixes #2667

Author: jonahgraham

.github/workflows/maven.yml

@@ -77,6 +77,7 @@ jobs:
         --fail-at-end
         -DskipNativeTests=false
         -DfailIfNoTests=false
+        ${{ contains(matrix.config.native, 'linux') && '-DexcludedGroups=gtk4-todo' || '' }}
         clean install
     - name: Performance tests
       if: contains(github.event.pull_request.labels.*.name, 'performance')

bundles/org.eclipse.swt/Eclipse SWT WebKit/gtk/library/webkitgtk.c

@@ -243,6 +243,186 @@ JNIEXPORT jlong JNICALL WebKitGTK_NATIVE(JSValueToStringCopy)
 }
 #endif
 
+#ifndef NO_jsc_1value_1is_1boolean
+JNIEXPORT jboolean JNICALL WebKitGTK_NATIVE(jsc_1value_1is_1boolean)
+	(JNIEnv *env, jclass that, jlong arg0)
+{
+	jboolean rc = 0;
+	WebKitGTK_NATIVE_ENTER(env, that, jsc_1value_1is_1boolean_FUNC);
+/*
+	rc = (jboolean)jsc_value_is_boolean(arg0);
+*/
+	{
+		WebKitGTK_LOAD_FUNCTION(fp, jsc_value_is_boolean)
+		if (fp) {
+			rc = (jboolean)((jboolean (CALLING_CONVENTION*)(jlong))fp)(arg0);
+		}
+	}
+	WebKitGTK_NATIVE_EXIT(env, that, jsc_1value_1is_1boolean_FUNC);
+	return rc;
+}
+#endif
+
+#ifndef NO_jsc_1value_1is_1null
+JNIEXPORT jboolean JNICALL WebKitGTK_NATIVE(jsc_1value_1is_1null)
+	(JNIEnv *env, jclass that, jlong arg0)
+{
+	jboolean rc = 0;
+	WebKitGTK_NATIVE_ENTER(env, that, jsc_1value_1is_1null_FUNC);
+/*
+	rc = (jboolean)jsc_value_is_null(arg0);
+*/
+	{
+		WebKitGTK_LOAD_FUNCTION(fp, jsc_value_is_null)
+		if (fp) {
+			rc = (jboolean)((jboolean (CALLING_CONVENTION*)(jlong))fp)(arg0);
+		}
+	}
+	WebKitGTK_NATIVE_EXIT(env, that, jsc_1value_1is_1null_FUNC);
+	return rc;
+}
+#endif
+
+#ifndef NO_jsc_1value_1is_1number
+JNIEXPORT jboolean JNICALL WebKitGTK_NATIVE(jsc_1value_1is_1number)
+	(JNIEnv *env, jclass that, jlong arg0)
+{
+	jboolean rc = 0;
+	WebKitGTK_NATIVE_ENTER(env, that, jsc_1value_1is_1number_FUNC);
+/*
+	rc = (jboolean)jsc_value_is_number(arg0);
+*/
+	{
+		WebKitGTK_LOAD_FUNCTION(fp, jsc_value_is_number)
+		if (fp) {
+			rc = (jboolean)((jboolean (CALLING_CONVENTION*)(jlong))fp)(arg0);
+		}
+	}
+	WebKitGTK_NATIVE_EXIT(env, that, jsc_1value_1is_1number_FUNC);
+	return rc;
+}
+#endif
+
+#ifndef NO_jsc_1value_1is_1object
+JNIEXPORT jboolean JNICALL WebKitGTK_NATIVE(jsc_1value_1is_1object)
+	(JNIEnv *env, jclass that, jlong arg0)
+{
+	jboolean rc = 0;
+	WebKitGTK_NATIVE_ENTER(env, that, jsc_1value_1is_1object_FUNC);
+/*
+	rc = (jboolean)jsc_value_is_object(arg0);
+*/
+	{
+		WebKitGTK_LOAD_FUNCTION(fp, jsc_value_is_object)
+		if (fp) {
+			rc = (jboolean)((jboolean (CALLING_CONVENTION*)(jlong))fp)(arg0);
+		}
+	}
+	WebKitGTK_NATIVE_EXIT(env, that, jsc_1value_1is_1object_FUNC);
+	return rc;
+}
+#endif
+
+#ifndef NO_jsc_1value_1is_1string
+JNIEXPORT jboolean JNICALL WebKitGTK_NATIVE(jsc_1value_1is_1string)
+	(JNIEnv *env, jclass that, jlong arg0)
+{
+	jboolean rc = 0;
+	WebKitGTK_NATIVE_ENTER(env, that, jsc_1value_1is_1string_FUNC);
+/*
+	rc = (jboolean)jsc_value_is_string(arg0);
+*/
+	{
+		WebKitGTK_LOAD_FUNCTION(fp, jsc_value_is_string)
+		if (fp) {
+			rc = (jboolean)((jboolean (CALLING_CONVENTION*)(jlong))fp)(arg0);
+		}
+	}
+	WebKitGTK_NATIVE_EXIT(env, that, jsc_1value_1is_1string_FUNC);
+	return rc;
+}
+#endif
+
+#ifndef NO_jsc_1value_1is_1undefined
+JNIEXPORT jboolean JNICALL WebKitGTK_NATIVE(jsc_1value_1is_1undefined)
+	(JNIEnv *env, jclass that, jlong arg0)
+{
+	jboolean rc = 0;
+	WebKitGTK_NATIVE_ENTER(env, that, jsc_1value_1is_1undefined_FUNC);
+/*
+	rc = (jboolean)jsc_value_is_undefined(arg0);
+*/
+	{
+		WebKitGTK_LOAD_FUNCTION(fp, jsc_value_is_undefined)
+		if (fp) {
+			rc = (jboolean)((jboolean (CALLING_CONVENTION*)(jlong))fp)(arg0);
+		}
+	}
+	WebKitGTK_NATIVE_EXIT(env, that, jsc_1value_1is_1undefined_FUNC);
+	return rc;
+}
+#endif
+
+#ifndef NO_jsc_1value_1to_1boolean
+JNIEXPORT jboolean JNICALL WebKitGTK_NATIVE(jsc_1value_1to_1boolean)
+	(JNIEnv *env, jclass that, jlong arg0)
+{
+	jboolean rc = 0;
+	WebKitGTK_NATIVE_ENTER(env, that, jsc_1value_1to_1boolean_FUNC);
+/*
+	rc = (jboolean)jsc_value_to_boolean(arg0);
+*/
+	{
+		WebKitGTK_LOAD_FUNCTION(fp, jsc_value_to_boolean)
+		if (fp) {
+			rc = (jboolean)((jboolean (CALLING_CONVENTION*)(jlong))fp)(arg0);
+		}
+	}
+	WebKitGTK_NATIVE_EXIT(env, that, jsc_1value_1to_1boolean_FUNC);
+	return rc;
+}
+#endif
+
+#ifndef NO_jsc_1value_1to_1double
+JNIEXPORT jdouble JNICALL WebKitGTK_NATIVE(jsc_1value_1to_1double)
+	(JNIEnv *env, jclass that, jlong arg0)
+{
+	jdouble rc = 0;
+	WebKitGTK_NATIVE_ENTER(env, that, jsc_1value_1to_1double_FUNC);
+/*
+	rc = (jdouble)jsc_value_to_double(arg0);
+*/
+	{
+		WebKitGTK_LOAD_FUNCTION(fp, jsc_value_to_double)
+		if (fp) {
+			rc = (jdouble)((jdouble (CALLING_CONVENTION*)(jlong))fp)(arg0);
+		}
+	}
+	WebKitGTK_NATIVE_EXIT(env, that, jsc_1value_1to_1double_FUNC);
+	return rc;
+}
+#endif
+
+#ifndef NO_jsc_1value_1to_1string
+JNIEXPORT jlong JNICALL WebKitGTK_NATIVE(jsc_1value_1to_1string)
+	(JNIEnv *env, jclass that, jlong arg0)
+{
+	jlong rc = 0;
+	WebKitGTK_NATIVE_ENTER(env, that, jsc_1value_1to_1string_FUNC);
+/*
+	rc = (jlong)jsc_value_to_string(arg0);
+*/
+	{
+		WebKitGTK_LOAD_FUNCTION(fp, jsc_value_to_string)
+		if (fp) {
+			rc = (jlong)((jlong (CALLING_CONVENTION*)(jlong))fp)(arg0);
+		}
+	}
+	WebKitGTK_NATIVE_EXIT(env, that, jsc_1value_1to_1string_FUNC);
+	return rc;
+}
+#endif
+
 #ifndef NO_soup_1cookie_1get_1name
 JNIEXPORT jlong JNICALL WebKitGTK_NATIVE(soup_1cookie_1get_1name)
 	(JNIEnv *env, jclass that, jlong arg0)
@@ -1225,6 +1405,46 @@ JNIEXPORT void JNICALL WebKitGTK_NATIVE(webkit_1javascript_1result_1unref)
 }
 #endif
 
+#ifndef NO_webkit_1navigation_1action_1get_1request
+JNIEXPORT jlong JNICALL WebKitGTK_NATIVE(webkit_1navigation_1action_1get_1request)
+	(JNIEnv *env, jclass that, jlong arg0)
+{
+	jlong rc = 0;
+	WebKitGTK_NATIVE_ENTER(env, that, webkit_1navigation_1action_1get_1request_FUNC);
+/*
+	rc = (jlong)webkit_navigation_action_get_request(arg0);
+*/
+	{
+		WebKitGTK_LOAD_FUNCTION(fp, webkit_navigation_action_get_request)
+		if (fp) {
+			rc = (jlong)((jlong (CALLING_CONVENTION*)(jlong))fp)(arg0);
+		}
+	}
+	WebKitGTK_NATIVE_EXIT(env, that, webkit_1navigation_1action_1get_1request_FUNC);
+	return rc;
+}
+#endif
+
+#ifndef NO_webkit_1navigation_1policy_1decision_1get_1navigation_1action
+JNIEXPORT jlong JNICALL WebKitGTK_NATIVE(webkit_1navigation_1policy_1decision_1get_1navigation_1action)
+	(JNIEnv *env, jclass that, jlong arg0)
+{
+	jlong rc = 0;
+	WebKitGTK_NATIVE_ENTER(env, that, webkit_1navigation_1policy_1decision_1get_1navigation_1action_FUNC);
+/*
+	rc = (jlong)webkit_navigation_policy_decision_get_navigation_action(arg0);
+*/
+	{
+		WebKitGTK_LOAD_FUNCTION(fp, webkit_navigation_policy_decision_get_navigation_action)
+		if (fp) {
+			rc = (jlong)((jlong (CALLING_CONVENTION*)(jlong))fp)(arg0);
+		}
+	}
+	WebKitGTK_NATIVE_EXIT(env, that, webkit_1navigation_1policy_1decision_1get_1navigation_1action_FUNC);
+	return rc;
+}
+#endif
+
 #ifndef NO_webkit_1navigation_1policy_1decision_1get_1request
 JNIEXPORT jlong JNICALL WebKitGTK_NATIVE(webkit_1navigation_1policy_1decision_1get_1request)
 	(JNIEnv *env, jclass that, jlong arg0)
@@ -1878,6 +2098,52 @@ JNIEXPORT jint JNICALL WebKitGTK_NATIVE(webkit_1web_1view_1can_1show_1mime_1type
 }
 #endif
 
+#ifndef NO_webkit_1web_1view_1evaluate_1javascript
+JNIEXPORT void JNICALL WebKitGTK_NATIVE(webkit_1web_1view_1evaluate_1javascript)
+	(JNIEnv *env, jclass that, jlong arg0, jbyteArray arg1, jlong arg2, jlong arg3, jlong arg4, jlong arg5, jlong arg6, jlong arg7)
+{
+	jbyte *lparg1=NULL;
+	WebKitGTK_NATIVE_ENTER(env, that, webkit_1web_1view_1evaluate_1javascript_FUNC);
+	if (arg1) if ((lparg1 = (*env)->GetByteArrayElements(env, arg1, NULL)) == NULL) goto fail;
+/*
+	webkit_web_view_evaluate_javascript(arg0, lparg1, arg2, arg3, arg4, arg5, arg6, arg7);
+*/
+	{
+		WebKitGTK_LOAD_FUNCTION(fp, webkit_web_view_evaluate_javascript)
+		if (fp) {
+			((void (CALLING_CONVENTION*)(jlong, jbyte *, jlong, jlong, jlong, jlong, jlong, jlong))fp)(arg0, lparg1, arg2, arg3, arg4, arg5, arg6, arg7);
+		}
+	}
+fail:
+	if (arg1 && lparg1) (*env)->ReleaseByteArrayElements(env, arg1, lparg1, 0);
+	WebKitGTK_NATIVE_EXIT(env, that, webkit_1web_1view_1evaluate_1javascript_FUNC);
+}
+#endif
+
+#ifndef NO_webkit_1web_1view_1evaluate_1javascript_1finish
+JNIEXPORT jlong JNICALL WebKitGTK_NATIVE(webkit_1web_1view_1evaluate_1javascript_1finish)
+	(JNIEnv *env, jclass that, jlong arg0, jlong arg1, jlongArray arg2)
+{
+	jlong *lparg2=NULL;
+	jlong rc = 0;
+	WebKitGTK_NATIVE_ENTER(env, that, webkit_1web_1view_1evaluate_1javascript_1finish_FUNC);
+	if (arg2) if ((lparg2 = (*env)->GetLongArrayElements(env, arg2, NULL)) == NULL) goto fail;
+/*
+	rc = (jlong)webkit_web_view_evaluate_javascript_finish(arg0, arg1, (GError **)lparg2);
+*/
+	{
+		WebKitGTK_LOAD_FUNCTION(fp, webkit_web_view_evaluate_javascript_finish)
+		if (fp) {
+			rc = (jlong)((jlong (CALLING_CONVENTION*)(jlong, jlong, GError **))fp)(arg0, arg1, (GError **)lparg2);
+		}
+	}
+fail:
+	if (arg2 && lparg2) (*env)->ReleaseLongArrayElements(env, arg2, lparg2, 0);
+	WebKitGTK_NATIVE_EXIT(env, that, webkit_1web_1view_1evaluate_1javascript_1finish_FUNC);
+	return rc;
+}
+#endif
+
 #ifndef NO_webkit_1web_1view_1get_1context
 JNIEXPORT jlong JNICALL WebKitGTK_NATIVE(webkit_1web_1view_1get_1context)
 	(JNIEnv *env, jclass that, jlong arg0)

bundles/org.eclipse.swt/Eclipse SWT WebKit/gtk/library/webkitgtk.h

@@ -52,6 +52,7 @@
 		} \
 		if (handle) { \
 			var = dlsym(handle,	#name); \
+			if (!var) {	g_critical("SWT webkitgtk: Failed to load webkit function %s", #name); } \
 		} \
 		CHECK_DLERROR \
 		initialized = 1; \

bundles/org.eclipse.swt/Eclipse SWT WebKit/gtk/library/webkitgtk_stats.h

@@ -34,6 +34,15 @@ typedef enum {
 	JSValueGetType_FUNC,
 	JSValueToNumber_FUNC,
 	JSValueToStringCopy_FUNC,
+	jsc_1value_1is_1boolean_FUNC,
+	jsc_1value_1is_1null_FUNC,
+	jsc_1value_1is_1number_FUNC,
+	jsc_1value_1is_1object_FUNC,
+	jsc_1value_1is_1string_FUNC,
+	jsc_1value_1is_1undefined_FUNC,
+	jsc_1value_1to_1boolean_FUNC,
+	jsc_1value_1to_1double_FUNC,
+	jsc_1value_1to_1string_FUNC,
 	soup_1cookie_1get_1name_FUNC,
 	soup_1cookie_1get_1value_FUNC,
 	soup_1cookie_1parse_FUNC,
@@ -82,6 +91,8 @@ typedef enum {
 	webkit_1javascript_1result_1get_1global_1context_FUNC,
 	webkit_1javascript_1result_1get_1value_FUNC,
 	webkit_1javascript_1result_1unref_FUNC,
+	webkit_1navigation_1action_1get_1request_FUNC,
+	webkit_1navigation_1policy_1decision_1get_1navigation_1action_FUNC,
 	webkit_1navigation_1policy_1decision_1get_1request_FUNC,
 	webkit_1network_1session_1get_1default_FUNC,
 	webkit_1policy_1decision_1download_FUNC,
@@ -114,6 +125,8 @@ typedef enum {
 	webkit_1web_1view_1can_1go_1back_FUNC,
 	webkit_1web_1view_1can_1go_1forward_FUNC,
 	webkit_1web_1view_1can_1show_1mime_1type_FUNC,
+	webkit_1web_1view_1evaluate_1javascript_FUNC,
+	webkit_1web_1view_1evaluate_1javascript_1finish_FUNC,
 	webkit_1web_1view_1get_1context_FUNC,
 	webkit_1web_1view_1get_1estimated_1load_1progress_FUNC,
 	webkit_1web_1view_1get_1find_1controller_FUNC,