Commit bd1cdd6
[GTK4] Fix GtkWidget warning when calculating initial shell bounds
It might be possible that no (custom) titlebar is set for the newly
created shell. In such a case, gtk_widget_measure() must not be called
with the NULL handle, in order to avoid the following error:
> gtk_widget_measure: assertion 'GTK_IS_WIDGET (widget)' failed
Furthermore, the header is now retrieved via gtk_window_get_titlebar(),
rather than assuming that it's the second child of the shell handle.1 parent 5d535ce commit bd1cdd6
File tree
4 files changed
+22
-5
lines changed- bundles/org.eclipse.swt
- Eclipse SWT PI/gtk
- library
- org/eclipse/swt/internal/gtk4
- Eclipse SWT/gtk/org/eclipse/swt/widgets
4 files changed
+22
-5
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | | - | |
| 2 | + | |
3 | 3 | | |
4 | 4 | | |
5 | 5 | | |
| |||
1870 | 1870 | | |
1871 | 1871 | | |
1872 | 1872 | | |
| 1873 | + | |
| 1874 | + | |
| 1875 | + | |
| 1876 | + | |
| 1877 | + | |
| 1878 | + | |
| 1879 | + | |
| 1880 | + | |
| 1881 | + | |
| 1882 | + | |
| 1883 | + | |
| 1884 | + | |
1873 | 1885 | | |
1874 | 1886 | | |
1875 | 1887 | | |
| |||
Lines changed: 2 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | | - | |
| 2 | + | |
3 | 3 | | |
4 | 4 | | |
5 | 5 | | |
| |||
164 | 164 | | |
165 | 165 | | |
166 | 166 | | |
| 167 | + | |
167 | 168 | | |
168 | 169 | | |
169 | 170 | | |
| |||
Lines changed: 2 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
324 | 324 | | |
325 | 325 | | |
326 | 326 | | |
| 327 | + | |
| 328 | + | |
327 | 329 | | |
328 | 330 | | |
329 | 331 | | |
| |||
Lines changed: 5 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | | - | |
| 2 | + | |
3 | 3 | | |
4 | 4 | | |
5 | 5 | | |
| |||
2541 | 2541 | | |
2542 | 2542 | | |
2543 | 2543 | | |
2544 | | - | |
| 2544 | + | |
2545 | 2545 | | |
2546 | | - | |
| 2546 | + | |
| 2547 | + | |
| 2548 | + | |
2547 | 2549 | | |
2548 | 2550 | | |
2549 | 2551 | | |
| |||
0 commit comments