Skip to content

Commit eb9e8d6

Browse files
committed
[Build] Replace use of coactions/setup-xvfb
Because GH workflows running on Windows by default use 'PowerShell Core' as shell all arguments that contain a dot have to be quoted because powershell interprets dots. Running SWT on a 'CMD' shell breaks some tests.
1 parent f95025e commit eb9e8d6

File tree

1 file changed

+8
-10
lines changed

1 file changed

+8
-10
lines changed

.github/workflows/maven.yml

Lines changed: 8 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -60,26 +60,24 @@ jobs:
6060
with:
6161
maven-version: 3.9.9
6262
- name: Build
63-
uses: coactions/setup-xvfb@6b00cf1889f4e1d5a48635647013c0508128ee1a
64-
with:
65-
run: >-
63+
run: >-
64+
${{ contains(matrix.config.native, 'linux') && 'xvfb-run' || '' }}
6665
mvn --batch-mode -V -U -e
6766
--threads 1C
6867
-DforkCount=1
69-
-Dnative=${{ matrix.config.native }}
68+
'-Dnative=${{ matrix.config.native }}'
7069
-Papi-check
71-
-Dtycho.baseline.replace=none
70+
'-Dtycho.baseline.replace=none'
7271
--fail-at-end
7372
-DskipNativeTests=false
7473
-DfailIfNoTests=false
75-
-Dtycho.version=4.0.8
74+
'-Dtycho.version=4.0.8'
7675
clean install
7776
- name: Performance tests
7877
if: contains(github.event.pull_request.labels.*.name, 'performance')
79-
uses: coactions/setup-xvfb@6b00cf1889f4e1d5a48635647013c0508128ee1a
80-
with:
81-
working-directory: tests/org.eclipse.swt.tests
82-
run: >-
78+
working-directory: tests/org.eclipse.swt.tests
79+
run: >-
80+
${{ contains(matrix.config.native, 'linux') && 'xvfb-run' || '' }}
8381
mvn --batch-mode -V -U -e
8482
-DforkCount=1
8583
--fail-at-end

0 commit comments

Comments
 (0)