New find/replace overlay broken under wayland

[akurtakov]

Trying to use new find/replace under Wayland is almost entirely impossible, It constantly moves and hides. Just watch the video

Screencast.from.2024-09-05.15-02-10.mp4

Environment:

1. Select the platform(s) on which the behavior is seen:

• • [x ] Linux

2. Additional OS info (e.g. OS version, Linux Desktop, etc)
   Fedora 40, Gnome on Wayland

3. JRE/JDK version
   Java 23

[akurtakov]

@jonahgraham @sratz That might be interesting for the IDE WG to look into as it will be a problem for users on latest Linux distros

[HeikoKlare]

I quickly reproduced the issue on WSL using Wayland. At least one reason seems to be this:

• Shell.setLocation doesn't work properly (or at all) on Wayland #790

Setting the shell's location (the one of the find/replace overlay shell) does not work, as also documented here: #790 (comment)
But the find/replace overlay implementation relies on this.

This means, the GTK Shell implementation does not behave API-conforming on Wayland. Isn't this an issue also in other use cases?
And just out of curiosity: Is there a reason for not adding a (temporary) comment to Shell's API that the method will not work on Wayland, given that this issue is known for quite some time now and given that we seem to want / claim SWT to be usable on Wayland?

[HeikoKlare]

We show a notification popup to users on first usage of the find/replace overlay to switch back to the existing find/replace dialog. This would give them the chance to easily switch to existing UI (they can of course still switch the UI in the preferences later on).
Unfortunately, this notification popup does also not work properly because of the same issue. Popups also use the Shell#setLocation() functionality: https://github.com/eclipse-platform/eclipse.platform.ui/blob/31a902749e53ae095fb98c40459ba8cfc70d6d0d/bundles/org.eclipse.jface.notifications/src/org/eclipse/jface/notifications/AbstractNotificationPopup.java#L422-L423