These webkit constants have the wrong value

[jonahgraham]

These constants:

eclipse.platform.swt/bundles/org.eclipse.swt/Eclipse SWT WebKit/gtk/org/eclipse/swt/internal/webkit/WebKitGTK.java

Lines 79 to 87 in 5edaae0

	public static final int G_TLS_CERTIFICATE_UNKNOWN_CA = 0;
	public static final int G_TLS_CERTIFICATE_BAD_IDENTITY = 1;
	public static final int G_TLS_CERTIFICATE_NOT_ACTIVATED = 2;
	public static final int G_TLS_CERTIFICATE_EXPIRED = 3;
	public static final int G_TLS_CERTIFICATE_REVOKED = 4;
	public static final int G_TLS_CERTIFICATE_INSECURE = 5;
	public static final int G_TLS_CERTIFICATE_GENERIC_ERROR = 6;
	public static final int G_TLS_CERTIFICATE_VALIDATE_ALL = 7;

Which are used to convert error number to message here

eclipse.platform.swt/bundles/org.eclipse.swt/Eclipse SWT WebKit/gtk/org/eclipse/swt/browser/WebKit.java

Line 2537 in 210dfa9

case WebKitGTK.G_TLS_CERTIFICATE_NOT_ACTIVATED: {

are wrong.

They should be 1<<N instead of N.

[jonahgraham]

The correct value in gio source but I don't know where the docs are for this. I thought they would be https://docs.gtk.org/gio but 🤷

[akurtakov]

It's supposed to be listed at https://docs.gtk.org/gio/index.html#enums according to me. I don't know whether you want to open an issue for them to fix it.

[jonahgraham]

I filed the issue https://gitlab.gnome.org/GNOME/glib/-/issues/3815 and while filing it I found the page https://docs.gtk.org/gio/flags.TlsCertificateFlags.html is there but not linked from enums section.

[jonahgraham]

Ahh! They are bitfields, not enums - https://docs.gtk.org/gio/index.html#bitfields