[GTK4] Migrate deprecated ColorChooser to ColorDialog

[ptziegler]

The Color Chooser has been moved to the GTK3 class and all references inside the GTK4 blocks have been updated to use the new API.

Note that the GTK4 API doesn't provide the means to set a custom palette, meaning that the colors specified with setRGBS(RGB[]) are effectively ignored.

[ptziegler]

GTK3:

GTK4:

[github-actions]

Test Results

   502 files  + 1     502 suites  +1   10m 36s ⏱️ - 3m 47s
 4 334 tests +37   4 320 ✅ +35   14 💤 +3  0 ❌  - 1 
16 575 runs  +37  16 466 ✅ +35  109 💤 +3  0 ❌  - 1 

Results for commit d9df766. ± Comparison against base commit b4fabe5.

♻️ This comment has been updated with latest results.

[akurtakov]

Would you please rebase on master and remove the draft if you agree that it's time to get this one in.

[ptziegler]

Would you please rebase on master and remove the draft if you agree that it's time to get this one in.

I only wanted to revisit the issue with the modal dialog but that has now been fixed. I don't see any (additional) warnings when trying out the snippets so I think this is done for now.

[akurtakov]

There is one fundamental problem - the gtk_color_dialog calls are guarded with if( GTK4) blocks but they are introduced in gtk 4.10 so these symbols will simply fail to load (hard crash) if swt is run on gtk 4.0-4.8.
I believe the ColorChooser API should stay in GTK class and be used till gtk 4.8. The ColorDialog API should be guarded using if (GTK.GTK_VERSION >= OS.VERSION(4, 10, 0)) blocks.

[akurtakov]

Now I realize I missed the same problem in #1583 so we will have to redo it too.

[ptziegler]

Now I realize I missed the same problem in #1583 so we will have to redo it too.

I was just about to ask about the Font/Dialog chooser. I can have a look at it over the weekend.

[ptziegler]

Now I realize I missed the same problem in #1583 so we will have to redo it too.

#1793

[ptziegler]

I've also updated this PR to guard the ColorDialog API behind a "GTK 4.10" check. This should avoid the crash with older GTK4 versions.

[akurtakov]

This one is good to go.