Skip to content

Conversation

@HeikoKlare
Copy link
Contributor

Two snippets refer to an old signature of the ImageGcDrawer interface, leading to compilation issues. This change change adapts them accordingly.

Two snippets refer to an old signature of the ImageGcDrawer interface,
leading to compilation issues. This change change adapts them
accordingly.
@HeikoKlare HeikoKlare marked this pull request as ready for review January 19, 2025 16:19
@github-actions
Copy link
Contributor

Test Results

   493 files   -  1     493 suites   - 1   9m 14s ⏱️ +8s
 4 289 tests  - 37   4 273 ✅  - 35   15 💤  - 3  0 ❌ ±0  1 🔥 +1 
16 499 runs   - 37  16 354 ✅  - 34  144 💤  - 4  0 ❌ ±0  1 🔥 +1 

For more details on these errors, see this check.

Results for commit 4fae5a8. ± Comparison against base commit c493ae8.

This pull request removes 37 tests.
org.eclipse.swt.graphics.ImageWin32Tests ‑ testImageDataForDifferentFractionalZoomsShouldBeDifferent
org.eclipse.swt.graphics.ImageWin32Tests ‑ testImageShouldHaveDimesionAsPerZoomLevel
org.eclipse.swt.tests.win32.Test_org_eclipse_swt_dnd_DND ‑ testByteArrayTransfer
org.eclipse.swt.tests.win32.Test_org_eclipse_swt_dnd_DND ‑ testFileTransfer
org.eclipse.swt.tests.win32.Test_org_eclipse_swt_dnd_DND ‑ testHtmlTransfer
org.eclipse.swt.tests.win32.Test_org_eclipse_swt_dnd_DND ‑ testImageTransfer_fromCopiedImage
org.eclipse.swt.tests.win32.Test_org_eclipse_swt_dnd_DND ‑ testImageTransfer_fromImage
org.eclipse.swt.tests.win32.Test_org_eclipse_swt_dnd_DND ‑ testImageTransfer_fromImageData
org.eclipse.swt.tests.win32.Test_org_eclipse_swt_dnd_DND ‑ testImageTransfer_fromImageDataFromImage
org.eclipse.swt.tests.win32.Test_org_eclipse_swt_dnd_DND ‑ testRtfTransfer
…

@HeikoKlare
Copy link
Contributor Author

Snippets are not compiled in CI anyway.

@HeikoKlare HeikoKlare merged commit d441a95 into eclipse-platform:master Jan 19, 2025
12 of 14 checks passed
@HeikoKlare HeikoKlare deleted the snippet-imagegcdrawer-compilation branch January 19, 2025 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant