[win32] Refresh thread dpi awareness on hooks #1813
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
akoch-yatta
force-pushed
the
ensure-thread-dpi-awareness
branch
from
4e3ac99 to
c9dc6e1
Compare
HeikoKlare
reviewed
Feb 10, 2025
bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/widgets/Display.java
Outdated
Show resolved
Hide resolved
akoch-yatta
force-pushed
the
ensure-thread-dpi-awareness
branch
from
c9dc6e1 to
e36c58e
Compare
akoch-yatta
force-pushed
the
ensure-thread-dpi-awareness
branch
from
e36c58e to
918acf9
Compare
HeikoKlare
reviewed
Feb 11, 2025
bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/widgets/Display.java
Show resolved
Hide resolved
bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/widgets/Display.java
Outdated
Show resolved
Hide resolved
akoch-yatta
force-pushed
the
ensure-thread-dpi-awareness
branch
4 times, most recently
from
0621463 to
6e894e8
Compare
HeikoKlare
force-pushed
the
ensure-thread-dpi-awareness
branch
2 times, most recently
from
a2c916f to
7cd0244
Compare
akoch-yatta
force-pushed
the
ensure-thread-dpi-awareness
branch
from
7cd0244 to
a81956e
Compare
This commit resets the DPI awareness for the WH_MSGFILTER hook, if called. For performance reasons that is only done, when runAsyncMessages will be triggered, as this can cause UI updates, which would be executed with the wrong DPI awareness context and cause UI glitches.
HeikoKlare
force-pushed
the
ensure-thread-dpi-awareness
branch
from
a81956e to
1d1447f
Compare
HeikoKlare
approved these changes
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit resets the DPI awareness for the WH_MSGFILTER hook, if called. For performance reasons that is only done, when runAsyncMessages will be triggered, as this can cause UI updates, which would be executed with the wrong DPI awareness context and cause UI glitches.
How to reproduce
Have monitor specific scaling active and at least two monitors.
Bildschirmaufnahme.2025-02-10.121127.mp4