Improve scaling of SystemImage #62

[amartya4256]

This PR contributes to better scaling of Images obtained from Display::getSystemImage using better windows API LoadIconWithScaleDown for scaling. The new API also changes the old system icons to the modern Windows System Icons.
The idea is to have an ImageDataProvider for such Images which retrieve the image from the OS for the specified dimensions relevant to the zoom level and obtain its imageData instead of scaling the ImageData obtained from the handle of initialNativeZoom.

Standard Icons loaded using LoadImage (using user32.dll):

Standard Icons loaded using LoadIconWithScaleDown (using imageres.dll):

Contributes to
#62 and #127

[github-actions]

Test Results

   505 files   -  1     505 suites   - 1   7m 56s ⏱️ -5s
 4 304 tests  - 37   4 292 ✅  - 35   11 💤  - 3  1 ❌ +1 
16 560 runs   - 37  16 453 ✅  - 35  106 💤  - 3  1 ❌ +1 

For more details on these failures, see this check.

Results for commit f6f11bf. ± Comparison against base commit 9b1bcf4.

This pull request removes 37 tests.

org.eclipse.swt.graphics.ImageWin32Tests ‑ testImageDataForDifferentFractionalZoomsShouldBeDifferent
org.eclipse.swt.graphics.ImageWin32Tests ‑ testImageShouldHaveDimesionAsPerZoomLevel
org.eclipse.swt.tests.win32.Test_org_eclipse_swt_dnd_DND ‑ testByteArrayTransfer
org.eclipse.swt.tests.win32.Test_org_eclipse_swt_dnd_DND ‑ testFileTransfer
org.eclipse.swt.tests.win32.Test_org_eclipse_swt_dnd_DND ‑ testHtmlTransfer
org.eclipse.swt.tests.win32.Test_org_eclipse_swt_dnd_DND ‑ testImageTransfer_fromCopiedImage
org.eclipse.swt.tests.win32.Test_org_eclipse_swt_dnd_DND ‑ testImageTransfer_fromImage
org.eclipse.swt.tests.win32.Test_org_eclipse_swt_dnd_DND ‑ testImageTransfer_fromImageData
org.eclipse.swt.tests.win32.Test_org_eclipse_swt_dnd_DND ‑ testImageTransfer_fromImageDataFromImage
org.eclipse.swt.tests.win32.Test_org_eclipse_swt_dnd_DND ‑ testRtfTransfer
…

♻️ This comment has been updated with latest results.

[HeikoKlare]

At a first glance, the change looks sound and moving to up-to-date system icons that can be retrieved in proper scaling is great.

For now, I have one question regarding the used scale value.

[HeikoKlare]

In general, the change looks good. I've tested it and it also works quite fine. Only the sizes of the retrieved icons do not make sense to me.

[HeikoKlare]

Looks good now. When taking another look, I only came across a chance for a little code cleanup. Maybe you can update the PR to incorporate that.

[HeikoKlare]

Please revert the formatting changes reintroduced with the recent change.

[HeikoKlare]

Failing test is unrelated and documented: #1843

[HeikoKlare]

FTR: binaries successfully built and pushsed on 2nd attempt: d25bdc3