[win32] fix to use zoom dpi for fonts via display #1822
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
HeikoKlare
reviewed
Feb 11, 2025
Contributor
HeikoKlare
left a comment
HeikoKlare
left a comment
There was a problem hiding this comment.
The change is sound and fixes the described issue. I've also tested with different scenarios (both without monitor-specific scaling with DPI awareness "PerMonitorV2" and "System", as well as with monitor-specific scaling, moving between differently scaled monitors and changing primary monitor zoom).
@fedejeanne can you please still have a second look?
bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/internal/ScalingSWTFontRegistry.java
Show resolved
Hide resolved
With commit cd8bb13 we adapted the calcuation how to scale up fonts to fix the calculation for fonts used by the Printer. This introduced an issue if monitor-specific scaling is active and the primary monitor zoom is changed, because two different calculation were mixed now. This commit fixes this inconsistency.
This commit fixes the calculation of the height when scaling a font for a different zoom when monitor-specific scaling is active
akoch-yatta
force-pushed
the
fix-font-scaling-on-primary-monitor-change
branch
from
40807b0 to
4f96f76
Compare
fedejeanne
reviewed
Feb 11, 2025
Member
fedejeanne
left a comment
fedejeanne
left a comment
There was a problem hiding this comment.
I can't judge the code itself but I can confirm that the error is fixed by this PR 👍
Thank you @akoch-yatta !
HeikoKlare
approved these changes
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With commit cd8bb13 we adapted the calculation how to scale up fonts to fix the calculation for fonts used by the Printer. This introduced an issue if monitor-specific scaling is active and the primary monitor zoom is changed, because two different calculation were mixed now. This commit fixes this inconsistency.
How to reproduce
Some fonts will be scaled by the wrong factor
@HeikoKlare Can you have a look