Skip to content

Conversation

@laeubi
Copy link
Contributor

@laeubi laeubi commented Feb 15, 2025

This is a different approach to

this should reuse the usual workflow, but set the GTK4=1 when the PR is created with the gtk4 label ... as Jenkins is still running with gtk3 we still check both ways.

@laeubi laeubi added the gtk4 GTK4 issues label Feb 15, 2025
@laeubi laeubi force-pushed the run_with_gtk4_if_it_has_gtk4_label branch from e83a2c7 to 836b309 Compare February 15, 2025 06:47
@github-actions
Copy link
Contributor

github-actions bot commented Feb 15, 2025

Test Results

   502 files  ±0     502 suites  ±0   8m 26s ⏱️ -37s
 4 334 tests ±0   4 319 ✅  - 1   15 💤 +1  0 ❌ ±0 
16 575 runs  ±0  16 464 ✅  - 2  111 💤 +2  0 ❌ ±0 

Results for commit 48f491e. ± Comparison against base commit 857ac0b.

This pull request skips 1 test.
org.eclipse.swt.tests.junit.Test_org_eclipse_swt_browser_Browser ‑ test_setUrl_remote[browser flags: 0]

♻️ This comment has been updated with latest results.

@laeubi laeubi removed the gtk4 GTK4 issues label Feb 15, 2025
@laeubi laeubi force-pushed the run_with_gtk4_if_it_has_gtk4_label branch from 836b309 to 48f491e Compare February 15, 2025 07:08
@laeubi laeubi added the gtk4 GTK4 issues label Feb 15, 2025
@laeubi laeubi merged commit da081e9 into eclipse-platform:master Feb 15, 2025
15 of 19 checks passed
@ptziegler
Copy link
Contributor

Clean and simple. Thanks! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gtk4 GTK4 issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants