[Win32] Add SSO support for SWT Browser using Edge backend #1834
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sratz
requested changes
Feb 18, 2025
bundles/org.eclipse.swt/Eclipse SWT Browser/win32/org/eclipse/swt/browser/Edge.java
Show resolved
Hide resolved
bundles/org.eclipse.swt/Eclipse SWT Browser/win32/org/eclipse/swt/browser/Edge.java
Show resolved
Hide resolved
Contributor
Author
|
Hello @sratz , is there a chance that this could be included in the next release, since it doesn't come with an API breaking change, or will it only be in the one after that? |
konczdev
force-pushed
the
feature/sso-support
branch
from
2ac48bc to
a857c99
Compare
konczdev
force-pushed
the
feature/sso-support
branch
3 times, most recently
from
0899bdd to
26c8a80
Compare
konczdev
force-pushed
the
feature/sso-support
branch
from
26c8a80 to
1994ddf
Compare
sratz
reviewed
Mar 21, 2025
bundles/org.eclipse.swt/Eclipse SWT Browser/win32/org/eclipse/swt/browser/Edge.java
Outdated
Show resolved
Hide resolved
konczdev
force-pushed
the
feature/sso-support
branch
from
1994ddf to
b0cfa3d
Compare
Introduces a new system property to enable Single Sign-On: - org.eclipse.swt.browser.Edge.allowSingleSignOnUsingOSPrimaryAccount This allows SWT Browser to use the logged-in Windows account for SSO with Azure AD resources and Microsoft account-enabled websites when using the Edge backend.
konczdev
force-pushed
the
feature/sso-support
branch
from
b0cfa3d to
25ff0b4
Compare
sratz
approved these changes
Mar 31, 2025
Member
sratz
left a comment
sratz
left a comment
There was a problem hiding this comment.
Change looks good to me.
Any objections, @HeikoKlare?
Contributor
HeikoKlare
approved these changes
Apr 14, 2025
Contributor
HeikoKlare
left a comment
HeikoKlare
left a comment
There was a problem hiding this comment.
This looks sound, so no objections from my side.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR adds support for Single Sign-On (SSO) in SWT Browser (using Edge backend),
allowing the browser to leverage the user's Windows credentials for authentication with
Azure AD resources and Microsoft account-enabled websites.
Features
org.eclipse.swt.browser.Edge.allowSingleSignOnUsingOSPrimaryAccountControl.setDataImplementation Details
trueto enable the featureDocumentation
Related Links