[win32] Dynamic handle creation for Region #1881
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Test Results 509 files ±0 509 suites ±0 9m 24s ⏱️ +21s For more details on these failures, see this check. Results for commit 7290adb. ± Comparison against base commit 1f67f33. ♻️ This comment has been updated with latest results. |
akoch-yatta
force-pushed
the
win32-create-handles-on-demand
branch
3 times, most recently
from
7a4dd8c to
8dbbfc8
Compare
fedejeanne
reviewed
Mar 10, 2025
bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/graphics/Region.java
Show resolved
Hide resolved
bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/graphics/Region.java
Outdated
Show resolved
Hide resolved
bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/graphics/Region.java
Outdated
Show resolved
Hide resolved
bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/graphics/Region.java
Outdated
Show resolved
Hide resolved
akoch-yatta
force-pushed
the
win32-create-handles-on-demand
branch
2 times, most recently
from
a01f1a8 to
83269ba
Compare
This commit refactors Region in the win32 implementation to better support multiple handles for different zoom settings by creating all handles only on demand.
akoch-yatta
force-pushed
the
win32-create-handles-on-demand
branch
from
83269ba to
7290adb
Compare
HeikoKlare
approved these changes
Mar 14, 2025
Contributor
HeikoKlare
left a comment
HeikoKlare
left a comment
There was a problem hiding this comment.
@fedejeanne is this good to go from your side as well now?
fedejeanne
approved these changes
Mar 14, 2025
Member
|
Test failure is unrelated: #1843 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors Region in the win32 implementation to better support multiple handles for different zoom settings by creating all handles only on demand.