Fix Combo crash with Bug379271_ComboCaretLocationOffset on Gtk 4 #1882
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akurtakov
force-pushed
the
accessibilitygtk4
branch
from
3c93e9d to
bd3c796
Compare
Contributor
Member
Author
|
Natives rebuild fails on windows due to https://gitlab.eclipse.org/eclipsefdn/helpdesk/-/issues/5711 . As all the native variants are commmitted only if all succeed we have to wait for the issue to be resolved. |
akurtakov
force-pushed
the
accessibilitygtk4
branch
3 times, most recently
from
5b79655 to
13435ad
Compare
Method getCaretPosition is implemented with Gtk 4. The other method getCaredLocation is simply bypassed on Gtk 4 with TODO to prevent the crash for now.
akurtakov
force-pushed
the
accessibilitygtk4
branch
from
13435ad to
ff4e3d3
Compare
Member
Author
|
Test failure on Windows unrelated, merging. |
Contributor
|
FTR: binaries for this successfully generated and pushed: c1e0ef6 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Method getCaretPosition is implemented with Gtk 4. The other method getCaredLocation is simply bypassed on Gtk 4 with TODO to prevent the crash for now.