Skip to content

Conversation

@akurtakov
Copy link
Member

I missed that in
#1894

@github-actions
Copy link
Contributor

github-actions bot commented Mar 11, 2025

Test Results

   506 files  + 1     506 suites  +1   8m 41s ⏱️ +47s
 4 341 tests +37   4 327 ✅ +35   14 💤 +3  0 ❌  - 1 
16 597 runs  +37  16 488 ✅ +35  109 💤 +3  0 ❌  - 1 

Results for commit 6e0c6bc. ± Comparison against base commit a65e56a.

♻️ This comment has been updated with latest results.

@akurtakov
Copy link
Member Author

Warnings are coming from some previous change thus merging to move a step ahead at least.

@akurtakov akurtakov merged commit 632681f into eclipse-platform:master Mar 11, 2025
11 of 14 checks passed
@HeikoKlare
Copy link
Contributor

Warnings are coming from some previous change

Just to understand this correctly: it's just because we have some flaky behavior of the analysis in SWT so that sometimes the used reference master build has 33 warnings and sometimes it has 43, don't we? Or was there actually a previous change that needs to be revised?

@akurtakov
Copy link
Member Author

@HeikoKlare Comparison is done against latest master build (

discoverGitReferenceBuild referenceJob: 'eclipse.platform.swt/master'
) so when a PR that increases issues is pushed and built in master the new "baseline" becomes with higher number of warnings and thus these "new" issues will no longer be reported as new.
Overtime this leads to gradual increase of warnings and decrease in code quality, unfortunately we had to go that path as using a baseline that marks any increase of warnings as failing builds led to people ignoring results even more. Long story short - there seems to be no way to make people care about that :( .

@HeikoKlare
Copy link
Contributor

@akurtakov Yes, I know that latest master build is always taken as baseline, so if you merge something with new warnings, that will implicitly become the new baseline without further notice.

Still, I think we have a different "issue" here (related to the tooling) and there were no warnings introduced in the recent past: the reported warnings for SWT master builds are flaky. Sometimes there are 33, sometimes there are 43. See for example the latest master build (https://ci.eclipse.org/releng/job/eclipse.platform.swt/job/master/991/):
image
And the previous one (https://ci.eclipse.org/releng/job/eclipse.platform.swt/job/master/989/):
image

The latest build used for reference will always have 33 issues reported, as builds with more issues (like the most recent master build with 43 issues) will be marked as instable and not taken as reference. So if your PR is built unluckily built with 43 warnings (even though you did not introduce new ones and no recent PR did either), you will see the check failing.

@akurtakov
Copy link
Member Author

I have no explanation for such behavior. It would need separate tracking and investigation.

@HeikoKlare
Copy link
Contributor

The behavior has been there for quite a while, but it does not occur that often and did bother us that much that anyone cared. I justed wanted to make aware that such reported warnings may just be a CI glitch and do not necessarily point to an actual quality degradation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants