Preserved width/height on scaleUp/Down a Rectangle #2047
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Test Results 545 files 545 suites 26m 26s ⏱️ Results for commit 75b80d7. ♻️ This comment has been updated with latest results. |
akoch-yatta
force-pushed
the
Fix-scaling-of-rectangles
branch
from
742add3 to
57aaf23
Compare
HeikoKlare
approved these changes
Apr 22, 2025
Contributor
HeikoKlare
left a comment
HeikoKlare
left a comment
There was a problem hiding this comment.
The change is sound and properly solves #2003
I couldn't find any unexpected side effects so far, so let's give this a try.
HeikoKlare
force-pushed
the
Fix-scaling-of-rectangles
branch
from
57aaf23 to
50376ac
Compare
This commit extends the logic when a Rectangle is scaled up/down from points to pixels regarding width and height. Fixes eclipse-platform#2003
HeikoKlare
force-pushed
the
Fix-scaling-of-rectangles
branch
from
50376ac to
75b80d7
Compare
Contributor
|
Merging this despite Jenkins failure caused by https://gitlab.eclipse.org/eclipsefdn/helpdesk/-/issues/5892 Since master builds seem to still work on Jenkins, the subsequent master build should hopefully work, thus I will check results of that build to retrospectively validate this PR. |
Contributor
|
No new issues on subsequent master build for d4caabf |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit extends the logic when a Rectangle is scaled up/down from points to pixels regarding width and height.
Fixes #2003