[GTK] Remove more *InPixels method #2101
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They are not needed at all, double some calls (like checkWidget()), and overall complicate debugging and understanding the codebase. Continuation of eclipse-platform#2100
Contributor
Test Results 539 files ±0 539 suites ±0 34m 57s ⏱️ + 1m 39s For more details on these failures, see this check. Results for commit cd1d9ac. ± Comparison against base commit af044d9. |
akurtakov
added a commit
to akurtakov/eclipse.platform.swt
that referenced
this pull request
May 6, 2025
Remove nowadays useless extra methods that even has the bad side effect of duplicating checks. Continuation of eclipse-platform#2101
akurtakov
added a commit
that referenced
this pull request
May 6, 2025
Remove nowadays useless extra methods that even has the bad side effect of duplicating checks. Continuation of #2101
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They are not needed at all, double some calls (like checkWidget()), and overall complicate debugging and understanding the codebase. Continuation of
#2100