Skip to content

Fix surefire warnings in build #2106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 7, 2025
Merged

Fix surefire warnings in build #2106

merged 1 commit into from
May 7, 2025

Conversation

@akurtakov
Copy link
Member

@akurtakov akurtakov commented May 6, 2025

Fixes following warnings in the build:

[WARNING] useSystemClassLoader setting has no effect when not forking
[WARNING] The parameter forkCount should likely not be 0. Forking a JVM
for tests improves test accuracy. Ensure to have a <forkCount> >= 1.

@akurtakov akurtakov force-pushed the master branch 2 times, most recently from 914ab70 to ddd2b70 Compare May 6, 2025 06:48
@github-actions
Copy link
Contributor

github-actions bot commented May 6, 2025 •
edited
Loading

Test Results

   539 files  ±0     539 suites  ±0   31m 5s ⏱️ - 3m 9s
 4 339 tests ±0   4 323 ✅ ±0   15 💤 ±0  1 ❌ ±0 
16 606 runs  ±0  16 468 ✅ ±0  137 💤 ±0  1 ❌ ±0 

For more details on these failures, see this check.

Results for commit eeae96a. ± Comparison against base commit 48cbec2.

♻️ This comment has been updated with latest results.

HannesWell
HannesWell reviewed May 6, 2025
View reviewed changes
@akurtakov
Fix surefire warnings in build
eeae96a 
Remove the override in jenkinsfile so the default is not overriden.

Fixes following warnings in the build:
```
[WARNING] useSystemClassLoader setting has no effect when not forking
[WARNING] The parameter forkCount should likely not be 0. Forking a JVM
for tests improves test accuracy. Ensure to have a <forkCount> >= 1.
```
@akurtakov akurtakov changed the title Add forkCount for surefire Fix surefire warnings in build May 7, 2025
@akurtakov
Copy link
Member Author

akurtakov commented May 7, 2025

Windows test failure is in master for long time. @HeikoKlare @fedejeanne What is the plan for this windows test failure? If there is none I'll disable it on Monday.

@akurtakov akurtakov merged commit a1d0720 into eclipse-platform:master May 7, 2025
15 of 17 checks passed
@github-project-automation github-project-automation bot moved this to Done in SWT work May 7, 2025
@fedejeanne fedejeanne mentioned this pull request May 7, 2025
Merged
@HeikoKlare
Copy link
Contributor

HeikoKlare commented May 7, 2025

What is the plan for this windows test failure? If there is none I'll disable it on Monday.

It was a a sporadically failing test for a while (only failing in GHA). It just started to fail rather consistently on Jenkins. It was not reproducible locally. I was now able to reproduce it on a system with a recent Windows build, so might be that we are now able to fix it via local reproduction. I added information in #1843.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@HannesWell HannesWell HannesWell left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@akurtakov @HeikoKlare @HannesWell