[win32] Always use GC#isDisposed() for check #2224
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
HeikoKlare
reviewed
Jun 13, 2025
Contributor
HeikoKlare
left a comment
HeikoKlare
left a comment
There was a problem hiding this comment.
A simple cleanup that is obviously fine.
I just wondered: should be take the chance and extract the actual check and error generation into a method checkNonDisposed or the like?
akoch-yatta
force-pushed
the
win32-GC-check-isDisposed
branch
from
fe59608 to
de53baa
Compare
Contributor
Author
Makes sense. I actually thought about that, but didn't do it yet for some reason. I adapted it now |
This commit replaces the handle == 0 checks in GC by using isDisposed instead
HeikoKlare
force-pushed
the
win32-GC-check-isDisposed
branch
from
de53baa to
cbbe0fe
Compare
laeubi
reviewed
Jun 14, 2025
|
|
||
| void copyAreaInPixels(Image image, int x, int y) { | ||
| if (handle == 0) SWT.error(SWT.ERROR_GRAPHIC_DISPOSED); | ||
| checkNonDisposed(); |
Contributor
There was a problem hiding this comment.
I'm not an expert regarding englisch language, but should it be checkNotDisposed? (like in "check it is not disposed"). I would probably simply name it checkDisposed like here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces the handle == 0 checks in GC by using isDisposed instead. It was done via search & replace