Refactor Image(Display, int, int) in Tests (Automated Tests) #2229
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShahzaibIbrahim
force-pushed
the
master-271-AutomatedTest
branch
from
bfb711c to
b3f16b6
Compare
4 tasks
Contributor
HeikoKlare
previously requested changes
Jun 16, 2025
....tests/JUnit Tests/org/eclipse/swt/tests/junit/Test_org_eclipse_swt_graphics_TextLayout.java
Outdated
Show resolved
Hide resolved
....tests/JUnit Tests/org/eclipse/swt/tests/junit/Test_org_eclipse_swt_graphics_TextLayout.java
Show resolved
Hide resolved
...e.swt.tests/JUnit Tests/org/eclipse/swt/tests/junit/Test_org_eclipse_swt_graphics_Image.java
Outdated
Show resolved
Hide resolved
...e.swt.tests/JUnit Tests/org/eclipse/swt/tests/junit/Test_org_eclipse_swt_graphics_Image.java
Outdated
Show resolved
Hide resolved
1 task
ShahzaibIbrahim
force-pushed
the
master-271-AutomatedTest
branch
4 times, most recently
from
d4290a1 to
41e5510
Compare
HeikoKlare
dismissed
their stale review
My crucial comments have been addressed, so in general the PR is fine now. Still this one is unresolved and it would be nice if that misleading comment could be fixed:
Contributor
|
The links in the review dismiss is wrong. I actually meant this comment: |
HeikoKlare
force-pushed
the
master-271-AutomatedTest
branch
from
41e5510 to
0ca9a23
Compare
Replacing Image(Display, int, int) with Image(Display, ImageGcDrawer, int, int) in automated test cases.
HeikoKlare
force-pushed
the
master-271-AutomatedTest
branch
from
0ca9a23 to
09b31e5
Compare
HeikoKlare
approved these changes
Jun 19, 2025
Contributor
HeikoKlare
left a comment
HeikoKlare
left a comment
There was a problem hiding this comment.
I've squashed the two commits.
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replacing Image(Display, int, int) with Image(Display, ImageGcDrawer, int, int) in Tests. Automated Test Case.