Refactor Image(Display, int, int) in Tests (Manual Test) #2230
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
Contributor
HeikoKlare
requested changes
Jun 16, 2025
...ests.win32/ManualTests/org/eclipse/swt/tests/win32/snippets/Bug563475_DarkDisabledTable.java
Show resolved
Hide resolved
ShahzaibIbrahim
force-pushed
the
master-271-ManualTests
branch
2 times, most recently
from
87b04d3 to
9724d86
Compare
HeikoKlare
reviewed
Jun 17, 2025
Contributor
HeikoKlare
left a comment
HeikoKlare
left a comment
There was a problem hiding this comment.
All adaptations are fine and the manual tests still work as before. There is only one change that needs to be revised.
...ManualTests/org/eclipse/swt/tests/win32/snippets/Bug560546_GC_drawString_vs_GC_drawText.java
Outdated
Show resolved
Hide resolved
ShahzaibIbrahim
force-pushed
the
master-271-ManualTests
branch
from
9724d86 to
5f7ddcd
Compare
Replacing Image(Display, int, int) with Image(Display, ImageGcDrawer, int, int) in Tests. Manual Tests.
ShahzaibIbrahim
force-pushed
the
master-271-ManualTests
branch
from
5f7ddcd to
0d443ed
Compare
HeikoKlare
approved these changes
Jun 18, 2025
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replacing Image(Display, int, int) with Image(Display, ImageGcDrawer, int, int) in Tests. Manual Tests.