[GTK4] Fix GtkWidget warning when updating shell bounds #2422
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Test Results 546 files ±0 546 suites ±0 34m 5s ⏱️ + 5m 6s Results for commit 3177545. ± Comparison against base commit d7f6b38. This pull request skips 1 test.♻️ This comment has been updated with latest results. |
Member
|
I have removed the gtk4 label and added it to the project instead. The gtk4 label causes linux verification gha to run with gtk4 but this still causes crash of the whole build. |
Member
|
Warning is printed on X11 only, the assumption seems to have been always correct on wayland but x11 wasn't considered at all. Very good catch for the gtk_window_get_titlebar usage! |
This is a continuation of bd1cdd6 where a 'GTK_IS_WIDGET (widget)' warning is logged when measuring the height of a NULL titlebar. This issue appears when e.g. calling setBounds() on a Shell. To reproduce this warning, run e.g. Snippet16.
akurtakov
force-pushed
the
gtk4-shell-warnings
branch
from
c1c154c to
3177545
Compare
akurtakov
approved these changes
Aug 16, 2025
Member
akurtakov
left a comment
akurtakov
left a comment
There was a problem hiding this comment.
Thanks for this one. As it touches GTK 4 code paths I merge it now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a continuation of bd1cdd6 where a 'GTK_IS_WIDGET (widget)' warning is logged when measuring the height of a NULL titlebar. This issue appears when e.g. calling setBounds() on a Shell.
To reproduce this warning, run e.g. Snippet16.