Scale Tree.INSET by zoom level instead of using fixed pixels #2429
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ShahzaibIbrahim
force-pushed
the
master-404-INSET
branch
2 times, most recently
from
396fbef to
458b970
Compare
arunjose696
reviewed
Aug 25, 2025
bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/widgets/TreeItem.java
Outdated
Show resolved
Hide resolved
Contributor
|
I tested the changes and can observe that the inset adjusts as mentioned in the issue. However, at 350% monitor zoom, the last character sometimes gets cut off. For example, when I right-click on the JRE System Library and choose Show in Project Explorer, the last closing bracket is not fully visible with the current changes.( 350% zoom) 
|
ShahzaibIbrahim
force-pushed
the
master-404-INSET
branch
2 times, most recently
from
2b28609 to
c1f96c1
Compare
Contributor
|
The issue I mentioned is resolved, and testing shows everything is working fine. I just have two questions about the change for clarification. |
arunjose696
reviewed
Aug 29, 2025
bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/widgets/TreeItem.java
Show resolved
Hide resolved
bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/widgets/TreeItem.java
Show resolved
Hide resolved
Contributor
|
I have tested the changes at my end at 100,200 and 350 zooms and everything seems to work fine, so approving this. |
arunjose696
approved these changes
Aug 29, 2025
akoch-yatta
force-pushed
the
master-404-INSET
branch
from
c1f96c1 to
0fdac1e
Compare
The Tree.INSET constant defines the spacing between an item's image and text. Previously, this was a fixed value of 3px, which looks correct at 100% zoom but causes the image and text to appear cramped on higher-DPI displays. This change defines INSET in points and converts it to pixels based on the current zoom level (e.g. 6px at 200%), ensuring consistent spacing across different monitor scales.
akoch-yatta
force-pushed
the
master-404-INSET
branch
from
0fdac1e to
1674026
Compare
fedejeanne
approved these changes
Sep 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Tree.INSET constant defines the spacing between an item's image and text. Previously, this was a fixed value of 3px, which looks correct at 100% zoom but causes the image and text to appear cramped on higher-DPI displays.
This change defines INSET in points and converts it to pixels based on the current zoom level (e.g. 6px at 200%), ensuring consistent spacing across different monitor scales.
Before Fix
After Fix
As we can see now the space between text and image in Tree is zoom relative.