Scale Tree.HEADER_MARGIN by zoom level instead of using fixed pixels #2430
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Test Results 546 files 546 suites 30m 15s ⏱️ Results for commit d05d80f. ♻️ This comment has been updated with latest results. |
Contributor
|
The change looks good to me. However, at 350% zoom, my measured pixel values using PowerToys are 233 (with the change) and 195 (without the change). Previously, the column width behaved inconsistently depending on how the header was created:
With this change, the column width is now consistent across both scenarios. |
arunjose696
approved these changes
Aug 25, 2025
The Tree.HEADER_MARGIN constant defines extra fixed-width spacing for tree headers. Previously, this was a fixed pixel value, which worked at 100% zoom but did not scale properly on high-DPI monitors. This change redefines HEADER_MARGIN in points and converts it to pixels based on the current zoom level, ensuring consistent header spacing across different display scales.
akoch-yatta
force-pushed
the
master-404-HEADER_MARGIN
branch
from
af8f888 to
d05d80f
Compare
akoch-yatta
approved these changes
Sep 3, 2025
Contributor
akoch-yatta
left a comment
akoch-yatta
left a comment
There was a problem hiding this comment.
Code looks fine and testing short changes work as expected
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Tree.HEADER_MARGIN and Tree.HEADER_EXTRA constant defines extra fixed-width spacing for tree headers. Previously, this was a fixed pixel value, which worked at 100% zoom but did not scale properly on high-DPI monitors.
This change redefines HEADER_MARGIN in points and converts it to pixels based on the current zoom level, ensuring consistent header spacing across different display scales.
Before and After
Header Width at 350% zoom