Scale Table.HEADER_MARGIN by zoom level instead of using fixed pixels #2454
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ShahzaibIbrahim
force-pushed
the
master-404-TABLE-HEADER
branch
from
ca5e3a8 to
e5ae157
Compare
ShahzaibIbrahim
force-pushed
the
master-404-TABLE-HEADER
branch
from
e5ae157 to
9eb9864
Compare
Contributor
Author
|
@akoch-yatta this PR was left behind as part of this ticket: vi-eclipse/Eclipse-Platform#404. Could you reveiw it? |
HeikoKlare
force-pushed
the
master-404-TABLE-HEADER
branch
from
9eb9864 to
5a708d8
Compare
ShahzaibIbrahim
force-pushed
the
master-404-TABLE-HEADER
branch
from
5a708d8 to
997d2a3
Compare
The Table.HEADER_MARGIN constant defines the extra fixed-width spacing for table headers, while the Table.HEADER_EXTRA constant specifies the additional spacing applied to the header area. Previously, both were defined as fixed pixel values, which worked at 100% zoom but did not scale properly on high-DPI monitors. This change redefines HEADER_MARGIN and HEADER_EXTRA in points and converts them to pixels based on the current zoom level, ensuring consistent header spacing across different display scales.
akoch-yatta
force-pushed
the
master-404-TABLE-HEADER
branch
from
e6a30a0 to
178f311
Compare
akoch-yatta
approved these changes
Oct 22, 2025
Contributor
akoch-yatta
left a comment
akoch-yatta
left a comment
There was a problem hiding this comment.
Change is small and makes sense in the context of monitor specific scaling. Didn't find a regression when testing it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Table.HEADER_MARGIN constant defines the extra fixed-width spacing for table headers, while the Table.HEADER_EXTRA constant specifies the additional spacing applied to the header area. Previously, both were defined as fixed pixel values,
which worked at 100% zoom but did not scale properly on high-DPI monitors.
This change redefines HEADER_MARGIN and HEADER_EXTRA in points and converts them to pixels based on the current zoom level, ensuring consistent header spacing across different display scales.
How to Test