Skip to content

Conversation

@HeikoKlare
Copy link
Contributor

  • makes multiple test methods with more comprehensive names out of a combined single one
  • adds test method for additional use case
  • adds win32-specific tests methods for specifics in Windows image handling

@github-actions
Copy link
Contributor

github-actions bot commented Aug 28, 2025

Test Results

   546 files  ± 0     546 suites  ±0   31m 20s ⏱️ - 1m 14s
 4 430 tests + 4   4 413 ✅ + 4   17 💤 ±0  0 ❌ ±0 
16 760 runs  +10  16 633 ✅ +10  127 💤 ±0  0 ❌ ±0 

Results for commit fc58c2c. ± Comparison against base commit f0e13ed.

This pull request removes 1 and adds 5 tests. Note that renamed tests count towards both.
org.eclipse.swt.tests.junit.Test_org_eclipse_swt_graphics_Image ‑ test_getImageData
AllWin32Tests ImageWin32Tests ‑ test_getImageData_fromCopiedImage
AllWin32Tests ImageWin32Tests ‑ test_getImageData_fromImageForImageDataFromImage
org.eclipse.swt.tests.junit.Test_org_eclipse_swt_graphics_Image ‑ test_getImageData_fromFiles
org.eclipse.swt.tests.junit.Test_org_eclipse_swt_graphics_Image ‑ test_getImageData_fromImage
org.eclipse.swt.tests.junit.Test_org_eclipse_swt_graphics_Image ‑ test_getImageData_fromImageForCustomImageData

♻️ This comment has been updated with latest results.

@HeikoKlare HeikoKlare marked this pull request as ready for review August 29, 2025 07:58
@eclipse-platform-bot
Copy link
Contributor

eclipse-platform-bot commented Sep 1, 2025

This pull request changes some projects for the first time in this development cycle.
Therefore the following files need a version increment:

tests/org.eclipse.swt.tests/META-INF/MANIFEST.MF
tests/org.eclipse.swt.tests/pom.xml

An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch.

Git patch
From 787959e7885a4044814a50ecc0a00bbd81951eac Mon Sep 17 00:00:00 2001
From: Eclipse Platform Bot <[email protected]>
Date: Sat, 6 Sep 2025 07:24:18 +0000
Subject: [PATCH] Version bump(s) for 4.38 stream


diff --git a/tests/org.eclipse.swt.tests/META-INF/MANIFEST.MF b/tests/org.eclipse.swt.tests/META-INF/MANIFEST.MF
index cf91c273eb..92d095fc15 100644
--- a/tests/org.eclipse.swt.tests/META-INF/MANIFEST.MF
+++ b/tests/org.eclipse.swt.tests/META-INF/MANIFEST.MF
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: Eclipse SWT Tests
 Bundle-SymbolicName: org.eclipse.swt.tests
-Bundle-Version: 3.107.900.qualifier
+Bundle-Version: 3.107.1000.qualifier
 Bundle-Vendor: Eclipse.org
 Export-Package: org.eclipse.swt.tests.junit,
  org.eclipse.swt.tests.junit.performance
diff --git a/tests/org.eclipse.swt.tests/pom.xml b/tests/org.eclipse.swt.tests/pom.xml
index 59df1ad54e..f8a6eb1865 100644
--- a/tests/org.eclipse.swt.tests/pom.xml
+++ b/tests/org.eclipse.swt.tests/pom.xml
@@ -20,7 +20,7 @@
     <relativePath>../../local-build/local-build-parent/</relativePath>
   </parent>
   <artifactId>org.eclipse.swt.tests</artifactId>
-  <version>3.107.900-SNAPSHOT</version>
+  <version>3.107.1000-SNAPSHOT</version>
   <packaging>eclipse-test-plugin</packaging>
   <properties>
     <tycho.testArgLine></tycho.testArgLine>
-- 
2.51.0

Further information are available in Common Build Issues - Missing version increments.

- makes multiple test methods with more comprehensive names out of a
combined single one
- adds test method for additional use case
- adds win32-specific tests methods for specifics in Windows image
handling
@HeikoKlare HeikoKlare merged commit ad53b13 into eclipse-platform:master Sep 6, 2025
17 checks passed
@HeikoKlare HeikoKlare deleted the improve-image-test branch September 6, 2025 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants