Skip to content

Remove the SORT_WIDTH spacing logic in Table column rendering. #2477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 12, 2025
+3 −8
Merged

Remove the SORT_WIDTH spacing logic in Table column rendering. #2477

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/widgets/Table.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,6 @@ public class Table extends Composite {
static /*final*/ long HeaderProc;
static final int INSET = 4;
static final int GRID_WIDTH = 1;
static final int SORT_WIDTH = 10;
static final int HEADER_MARGIN = 12;
static final int HEADER_EXTRA = 3;
static final int VISTA_EXTRA = 2;
Expand Down
10 changes: 3 additions & 7 deletions bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/widgets/TableColumn.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -408,14 +408,10 @@ public void pack () {
int headerWidth = (int)OS.SendMessage (hwnd, OS.LVM_GETSTRINGWIDTH, 0, buffer) + Table.HEADER_MARGIN;
if (OS.IsAppThemed ()) headerWidth += Table.HEADER_EXTRA;
boolean hasHeaderImage = false;
if (image != null || parent.sortColumn == this) {
if (image != null) {
hasHeaderImage = true;
if (parent.sortColumn == this && parent.sortDirection != SWT.NONE) {
headerWidth += Win32DPIUtils.pointToPixel(Table.SORT_WIDTH, getZoom());
} else if (image != null) {
Rectangle bounds = Win32DPIUtils.pointToPixel(image.getBounds(), getZoom());
headerWidth += bounds.width;
}
Rectangle bounds = Win32DPIUtils.pointToPixel(image.getBounds(), getZoom());
headerWidth += bounds.width;
long hwndHeader = OS.SendMessage (hwnd, OS.LVM_GETHEADER, 0, 0);
int margin = (int)OS.SendMessage (hwndHeader, OS.HDM_GETBITMAPMARGIN, 0, 0);
headerWidth += margin * 4;
Expand Down
Loading