Skip to content

Mark long-deprecated and unused SWT constants for removal #2715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Mark long-deprecated and unused SWT constants for removal #2715

wants to merge 1 commit into from
+5 −5

Conversation

@elsazac
Copy link
Member

@elsazac elsazac commented Oct 30, 2025

There are few constants in SWT that have been deprecated for a long time and are no longer referenced within the codebase.
This change adds Deprecated tags for those to indicate their planned removal in a future release.

@elsazac elsazac force-pushed the deprecatedConstants branch from a971208 to 95779d4 Compare October 30, 2025 14:24
@github-actions
Copy link
Contributor

github-actions bot commented Oct 30, 2025 •
edited
Loading

Test Results

  115 files   -  3    115 suites   - 3   11m 45s ⏱️ - 5m 10s
4 613 tests  - 37  4 597 ✅  - 36  16 💤  - 1  0 ❌ ±0 
  312 runs   - 18    309 ✅  - 17   3 💤  - 1  0 ❌ ±0 

Results for commit ab290fe. ± Comparison against base commit 910f5cd.

This pull request removes 37 tests. 
AllGTKTests Test_GtkConverter ‑ test_HeuristicASCII_dollarSign
AllGTKTests Test_GtkConverter ‑ test_HeuristicASCII_emptyString
AllGTKTests Test_GtkConverter ‑ test_HeuristicASCII_letterA
AllGTKTests Test_GtkConverter ‑ test_HeuristicASCII_letters
AllGTKTests Test_GtkConverter ‑ test_HeuristicUTF16LE_null
AllGTKTests Test_GtkConverter ‑ test_HeuristicUTF16_AsciiLetters
AllGTKTests Test_GtkConverter ‑ test_HeuristicUTF16_Asciiletter
AllGTKTests Test_GtkConverter ‑ test_HeuristicUTF16_LotsOfLetters
AllGTKTests Test_GtkConverter ‑ test_HeuristicUTF16_letter
AllGTKTests Test_GtkConverter ‑ test_HeuristicUTF16_letters
…
This pull request skips 1 test. 
org.eclipse.swt.tests.junit.Test_org_eclipse_swt_widgets_Shell ‑ test_activateEventSend

♻️ This comment has been updated with latest results.

@elsazac
Copy link
Member Author

elsazac commented Oct 30, 2025

@HeikoKlare Could you check if this looks okay?

@elsazac elsazac force-pushed the deprecatedConstants branch from 95779d4 to 63df6e5 Compare October 31, 2025 11:58
@elsazac
Copy link
Member Author

elsazac commented Oct 31, 2025

I would like to merge this if there are no objections on this

@elsazac elsazac force-pushed the deprecatedConstants branch from 63df6e5 to f9e3020 Compare October 31, 2025 14:39
@elsazac
Copy link
Member Author

elsazac commented Oct 31, 2025

Build looks good, merging this now;

@elsazac elsazac force-pushed the deprecatedConstants branch from f9e3020 to ab290fe Compare October 31, 2025 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@elsazac