Skip to content

Commit 04265de

Browse files
committed
Fix org.eclipse.search.textSearchEngine ext point definition
1 parent 5ee9c26 commit 04265de

File tree

8 files changed

+54
-15
lines changed

8 files changed

+54
-15
lines changed

bundles/org.eclipse.search.core/META-INF/MANIFEST.MF

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
Manifest-Version: 1.0
22
Bundle-ManifestVersion: 2
33
Bundle-Name: %pluginName
4-
Bundle-SymbolicName: org.eclipse.search.core; singleton:=true
4+
Bundle-SymbolicName: org.eclipse.search.core;singleton:=true
55
Bundle-Version: 3.16.0.qualifier
66
Bundle-Activator: org.eclipse.search.internal.core.SearchCorePlugin
77
Bundle-ActivationPolicy: lazy

bundles/org.eclipse.search.core/plugin.properties

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
# IBM Corporation - initial API and implementation
1313
###############################################################################
1414

15-
pluginName= Search Support Core
16-
providerName= Eclipse.org
17-
dirtyFileSearchParticipant="Dirty File Search Participant"
18-
textSearchEngine="Text Search Engine"
15+
pluginName=Search Support Core
16+
providerName=Eclipse.org
17+
dirtyFileSearchParticipant=Dirty File Search Participant
18+
textSearchEngine=Text Search Engine
Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,8 @@
11
<?xml version="1.0" encoding="UTF-8"?>
2-
<?eclipse version="3.0"?>
3-
2+
<?eclipse version="3.2"?>
43
<!-- ======================================================================= -->
54
<!-- Search Plugin -->
65
<!-- ======================================================================= -->
76
<plugin>
8-
9-
<!-- Search extension point definitions -->
10-
<extension-point name="%textSearchEngine" id="textSearchEngine" schema="schema/textSearchEngine.exsd"/>
11-
7+
<extension-point id="org.eclipse.search.textSearchEngine" name="%textSearchEngine" schema="schema/textSearchEngine.exsd"/>
128
</plugin>

tests/org.eclipse.search.tests/META-INF/MANIFEST.MF

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
Manifest-Version: 1.0
22
Bundle-ManifestVersion: 2
33
Bundle-Name: %pluginName
4-
Bundle-SymbolicName: org.eclipse.search.tests
5-
Bundle-Version: 3.11.100.qualifier
4+
Bundle-SymbolicName: org.eclipse.search.tests;singleton:=true
5+
Bundle-Version: 3.11.200.qualifier
66
Bundle-Activator: org.eclipse.search.tests.SearchTestPlugin
77
Bundle-Vendor: %providerName
88
Bundle-Localization: plugin

tests/org.eclipse.search.tests/build.properties

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,8 @@ bin.includes = plugin.properties,\
1919
testresources/,\
2020
META-INF/,\
2121
about.html,\
22-
test.xml
22+
test.xml,\
23+
plugin.xml
2324

2425
# Maven/Tycho pom model adjustments
2526
pom.model.property.code.ignoredWarnings = ${tests.ignoredWarnings}
Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,13 @@
1+
<?xml version="1.0" encoding="UTF-8"?>
2+
<?eclipse version="3.4"?>
3+
<plugin>
4+
<extension
5+
point="org.eclipse.search.textSearchEngine">
6+
<textSearchEngine
7+
class="org.eclipse.search.tests.TestTextSearchEngine"
8+
id="org.eclipse.search.tests.testSearchEngine"
9+
label="Test Search Engine">
10+
</textSearchEngine>
11+
</extension>
12+
13+
</plugin>

tests/org.eclipse.search.tests/src/org/eclipse/search/tests/AllSearchTests.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,8 @@
2323
@RunWith(Suite.class)
2424
@SuiteClasses({
2525
AllFileSearchTests.class,
26-
AllSearchModelTests.class
26+
AllSearchModelTests.class,
27+
TextSearchRegistryTest.class
2728
})
2829
public class AllSearchTests {
2930
// see @SuiteClasses
Lines changed: 28 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,28 @@
1+
/*******************************************************************************
2+
* Copyright (c) 2023 Red Hat, Inc. and others.
3+
*
4+
* This program and the accompanying materials
5+
* are made available under the terms of the Eclipse Public License 2.0
6+
* which accompanies this distribution, and is available at
7+
* https://www.eclipse.org/legal/epl-2.0/
8+
*
9+
* SPDX-License-Identifier: EPL-2.0
10+
*******************************************************************************/
11+
package org.eclipse.search.tests;
12+
13+
import static org.junit.Assert.assertTrue;
14+
15+
import java.util.Arrays;
16+
17+
import org.eclipse.search.internal.core.text.TextSearchEngineRegistry;
18+
import org.eclipse.search.internal.ui.SearchPlugin;
19+
import org.junit.Test;
20+
21+
public class TextSearchRegistryTest {
22+
23+
@Test
24+
public void testRegistry() {
25+
TextSearchEngineRegistry textSearchEngineRegistry= SearchPlugin.getDefault().getTextSearchEngineRegistry();
26+
assertTrue(Arrays.stream(textSearchEngineRegistry.getAvailableEngines()).map(array -> array[1]).anyMatch("org.eclipse.search.tests.testSearchEngine"::equals));
27+
}
28+
}

0 commit comments

Comments
 (0)