Reduce 'new Class[]' cases

akurtakov · akurtakov · commit 04684550fee2 · 2025-01-22T10:07:46.000+02:00
Varargs, use {} for creating arrays and etc.
diff --git a/bundles/org.eclipse.core.databinding/src/org/eclipse/core/databinding/UpdateStrategy.java b/bundles/org.eclipse.core.databinding/src/org/eclipse/core/databinding/UpdateStrategy.java
@@ -1,5 +1,5 @@
 /*******************************************************************************
- * Copyright (c) 2007, 2018 IBM Corporation and others.
+ * Copyright (c) 2007, 2025 IBM Corporation and others.
  *
  * This program and the accompanying materials
  * are made available under the terms of the Eclipse Public License 2.0
@@ -422,12 +422,11 @@ private synchronized static Map<Pair, Object> getConverterMap() {
 		return converterMap;
 	}
 
-	private static final Class<?>[] integerClasses = new Class[] { byte.class,
-			Byte.class, short.class, Short.class, int.class, Integer.class,
-			long.class, Long.class, BigInteger.class };
+	private static final Class<?>[] integerClasses = { byte.class, Byte.class, short.class, Short.class, int.class,
+			Integer.class, long.class, Long.class, BigInteger.class };
 
-	private static final Class<?>[] floatClasses = new Class[] { float.class,
-			Float.class, double.class, Double.class, BigDecimal.class };
+	private static final Class<?>[] floatClasses = { float.class, Float.class, double.class, Double.class,
+			BigDecimal.class };
 
 	/**
 	 * Registers converters to boxed and unboxed types from a list of from
diff --git a/bundles/org.eclipse.core.databinding/src/org/eclipse/core/internal/databinding/ClassLookupSupport.java b/bundles/org.eclipse.core.databinding/src/org/eclipse/core/internal/databinding/ClassLookupSupport.java
@@ -1,5 +1,5 @@
 /*******************************************************************************
- * Copyright (c) 2006, 2015 IBM Corporation and others.
+ * Copyright (c) 2006, 2025 IBM Corporation and others.
  *
  * This program and the accompanying materials
  * are made available under the terms of the Eclipse Public License 2.0
@@ -53,7 +53,7 @@ public static Class<?>[] getTypeHierarchyFlattened(Class<?> type) {
 				classSearchOrderLookup = lookup = new HashMap<>();
 			lookup.put(type, classes);
 		}
-		return classes.toArray(new Class[classes.size()]);
+		return classes.toArray(Class[]::new);
 	}
 
 	/**
diff --git a/bundles/org.eclipse.core.databinding/src/org/eclipse/core/internal/databinding/conversion/IdentityConverter.java b/bundles/org.eclipse.core.databinding/src/org/eclipse/core/internal/databinding/conversion/IdentityConverter.java
@@ -1,5 +1,5 @@
 /*
- * Copyright (C) 2005, 2015 db4objects Inc.  http://www.db4o.com  and others.
+ * Copyright (C) 2005, 2025 db4objects Inc.  http://www.db4o.com  and others.
  *
  *
  * This program and the accompanying materials
@@ -37,7 +37,7 @@ public IdentityConverter(Class<?> fromType, Class<?> toType) {
 		this.toType = toType;
 	}
 
-	private Class<?>[][] primitiveMap = new Class[][] {
+	private Class<?>[][] primitiveMap = {
 			{ Integer.TYPE, Integer.class }, { Short.TYPE, Short.class },
 			{ Long.TYPE, Long.class }, { Double.TYPE, Double.class },
 			{ Byte.TYPE, Byte.class }, { Float.TYPE, Float.class },
diff --git a/bundles/org.eclipse.core.databinding/src/org/eclipse/core/internal/databinding/validation/ObjectToPrimitiveValidator.java b/bundles/org.eclipse.core.databinding/src/org/eclipse/core/internal/databinding/validation/ObjectToPrimitiveValidator.java
@@ -1,5 +1,5 @@
 /*******************************************************************************
- * Copyright (c) 2006, 2014 IBM Corporation and others.
+ * Copyright (c) 2006, 2025 IBM Corporation and others.
  *
  * This program and the accompanying materials
  * are made available under the terms of the Eclipse Public License 2.0
@@ -28,7 +28,7 @@ public class ObjectToPrimitiveValidator implements IValidator<Object> {
 
 	private Class<?> toType;
 
-	private Class<?>[][] primitiveMap = new Class[][] {
+	private Class<?>[][] primitiveMap = {
 			{ Integer.TYPE, Integer.class }, { Short.TYPE, Short.class },
 			{ Long.TYPE, Long.class }, { Double.TYPE, Double.class },
 			{ Byte.TYPE, Byte.class }, { Float.TYPE, Float.class },
diff --git a/bundles/org.eclipse.e4.ui.workbench.swt/src/org/eclipse/e4/ui/internal/workbench/swt/SelectionAdapterFactory.java b/bundles/org.eclipse.e4.ui.workbench.swt/src/org/eclipse/e4/ui/internal/workbench/swt/SelectionAdapterFactory.java
@@ -1,5 +1,5 @@
 /*******************************************************************************
- * Copyright (c) 2010, 2015 IBM Corporation and others.
+ * Copyright (c) 2010, 2025 IBM Corporation and others.
  *
  * This program and the accompanying materials
  * are made available under the terms of the Eclipse Public License 2.0
@@ -40,7 +40,7 @@ public class SelectionAdapterFactory implements IAdapterFactory {
 	/**
 	 * The classes we can adapt to.
 	 */
-	private static final Class<?>[] CLASSES = new Class[] { IIterable.class, ICountable.class };
+	private static final Class<?>[] CLASSES = { IIterable.class, ICountable.class };
 
 	@Override
 	public <T> T getAdapter(Object adaptableObject, Class<T> adapterType) {
diff --git a/bundles/org.eclipse.ui.editors/src/org/eclipse/ui/internal/editors/text/FileEditorInputAdapterFactory.java b/bundles/org.eclipse.ui.editors/src/org/eclipse/ui/internal/editors/text/FileEditorInputAdapterFactory.java
@@ -1,5 +1,5 @@
 /*******************************************************************************
- * Copyright (c) 2000, 2015 IBM Corporation and others.
+ * Copyright (c) 2000, 2025 IBM Corporation and others.
  *
  * This program and the accompanying materials
  * are made available under the terms of the Eclipse Public License 2.0
@@ -43,7 +43,7 @@ public IPath getPath(Object element) {
 	}
 
 	/** The list of provided adapters. */
-	private static final Class<?>[] ADAPTER_LIST= new Class[] { ILocationProvider.class };
+	private static final Class<?>[] ADAPTER_LIST = { ILocationProvider.class };
 
 	/** The provided location provider */
 	private ILocationProvider fLocationProvider= new LocationProvider();
diff --git a/bundles/org.eclipse.ui.editors/src/org/eclipse/ui/internal/editors/text/IURIEditorInputAdapterFactory.java b/bundles/org.eclipse.ui.editors/src/org/eclipse/ui/internal/editors/text/IURIEditorInputAdapterFactory.java
@@ -1,5 +1,5 @@
 /*******************************************************************************
- * Copyright (c) 2007, 2015 IBM Corporation and others.
+ * Copyright (c) 2007, 2025 IBM Corporation and others.
  *
  * This program and the accompanying materials
  * are made available under the terms of the Eclipse Public License 2.0
@@ -57,7 +57,7 @@ public URI getURI(Object element) {
 
 
 	/** The list of provided adapters. */
-	private static final Class<?>[] ADAPTER_LIST= new Class[] { ILocationProvider.class };
+	private static final Class<?>[] ADAPTER_LIST = { ILocationProvider.class };
 
 	/** The provided location provider */
 	private ILocationProvider fLocationProvider= new LocationProvider();
diff --git a/examples/org.eclipse.jface.examples.databinding/src/org/eclipse/jface/examples/databinding/ducks/ReflectedMethod.java b/examples/org.eclipse.jface.examples.databinding/src/org/eclipse/jface/examples/databinding/ducks/ReflectedMethod.java
@@ -1,5 +1,5 @@
 /*
- * Copyright (C) 2005, 2015 db4objects Inc.  http://www.db4o.com
+ * Copyright (C) 2005, 2025 db4objects Inc.  http://www.db4o.com
  *
  *
  * This program and the accompanying materials
@@ -35,7 +35,7 @@ public class ReflectedMethod {
 	 * @param methodName The name of the method.
 	 * @param paramTypes The method's parameter types.
 	 */
-	public ReflectedMethod(Object subject, String methodName, Class<?>[] paramTypes) {
+	public ReflectedMethod(Object subject, String methodName, Class<?>... paramTypes) {
 		this.subject = subject;
 		method = null;
 		try {
@@ -62,7 +62,7 @@ public boolean exists() {
 	 * @return any return value or null if there was no return value or an error
 	 *         occured.
 	 */
-	public Object invoke(Object[] params) {
+	public Object invoke(Object... params) {
 		if (method == null)
 			return null;
 		try {
diff --git a/examples/org.eclipse.jface.examples.databinding/src/org/eclipse/jface/examples/databinding/ducks/ReflectedProperty.java b/examples/org.eclipse.jface.examples.databinding/src/org/eclipse/jface/examples/databinding/ducks/ReflectedProperty.java
@@ -1,5 +1,5 @@
 /*******************************************************************************
- * Copyright (c) 2006, 2015 The Pampered Chef and others.
+ * Copyright (c) 2006, 2025 The Pampered Chef and others.
  *
  * This program and the accompanying materials
  * are made available under the terms of the Eclipse Public License 2.0
@@ -32,14 +32,14 @@ public class ReflectedProperty {
 	 */
 	public ReflectedProperty(Object object, String propertyName) {
 		this.propertyName = propertyName;
-		getter = new ReflectedMethod(object, makeGetterName(propertyName), new Class[] {});
+		getter = new ReflectedMethod(object, makeGetterName(propertyName));
 		if (!getter.exists()) {
-			getter = new ReflectedMethod(object, makeBooleanGetterName(propertyName), new Class[] {});
+			getter = new ReflectedMethod(object, makeBooleanGetterName(propertyName));
 			if (!getter.exists()) {
 				throw new IllegalArgumentException("Cannot find getter for " + propertyName);
 			}
 		}
-		setter = new ReflectedMethod(object, makeSetterName(propertyName), new Class[] { getter.getType() });
+		setter = new ReflectedMethod(object, makeSetterName(propertyName), getter.getType());
 	}
 
 	private String makeBooleanGetterName(String propertyName) {
diff --git a/examples/org.eclipse.jface.examples.databinding/src/org/eclipse/jface/examples/databinding/ducks/RelaxedDuckType.java b/examples/org.eclipse.jface.examples.databinding/src/org/eclipse/jface/examples/databinding/ducks/RelaxedDuckType.java
@@ -1,5 +1,5 @@
 /*
- * Copyright (C) 2005, 2015 db4objects Inc.  http://www.db4o.com
+ * Copyright (C) 2005, 2025 db4objects Inc.  http://www.db4o.com
  *
  *
  * This program and the accompanying materials
@@ -38,7 +38,7 @@ public static Object implement(Class<?> interfaceToImplement, Object object) {
 				new RelaxedDuckType(object));
 	}
 
-	public static boolean includes(Object object, String method, Class<?>[] args) {
+	public static boolean includes(Object object, String method, Class<?>... args) {
 		try {
 			object.getClass().getMethod(method, args);
 		} catch (NoSuchMethodException e) {
diff --git a/examples/org.eclipse.jface.snippets/Eclipse JFace Snippets/org/eclipse/jface/snippets/viewers/Snippet048TreeViewerTabWithCheckboxFor3_3.java b/examples/org.eclipse.jface.snippets/Eclipse JFace Snippets/org/eclipse/jface/snippets/viewers/Snippet048TreeViewerTabWithCheckboxFor3_3.java
@@ -1,5 +1,5 @@
 /*******************************************************************************
- * Copyright (c) 2006, 2018 Tom Schindl and others.
+ * Copyright (c) 2006, 2025 Tom Schindl and others.
  *
  * This program and the accompanying materials
  * are made available under the terms of the Eclipse Public License 2.0
@@ -191,7 +191,7 @@ protected void setValue(Object element, Object value) {
 				ViewerCell cell = mgr.getFocusCell();
 
 				try {
-					Method m = ColumnViewerEditor.class.getDeclaredMethod("processTraverseEvent", new Class[] {int.class,ViewerRow.class,TraverseEvent.class});
+					Method m = ColumnViewerEditor.class.getDeclaredMethod("processTraverseEvent", int.class,ViewerRow.class,TraverseEvent.class);
 					m.setAccessible(true);
 					m.invoke(editor, Integer.valueOf(cell.getColumnIndex()), cell.getViewerRow(), e);
 				} catch (SecurityException | NoSuchMethodException | IllegalArgumentException | IllegalAccessException | InvocationTargetException e1) {
diff --git a/tests/org.eclipse.core.filebuffers.tests/src/org/eclipse/core/filebuffers/tests/AbstractFileBufferDocCreationTests.java b/tests/org.eclipse.core.filebuffers.tests/src/org/eclipse/core/filebuffers/tests/AbstractFileBufferDocCreationTests.java
@@ -1,5 +1,5 @@
 /*******************************************************************************
- * Copyright (c) 2008 Symbian Software Systems, IBM Corporation and others.
+ * Copyright (c) 2008, 2025 Symbian Software Systems, IBM Corporation and others.
  *
  * This program and the accompanying materials
  * are made available under the terms of the Eclipse Public License 2.0
@@ -44,32 +44,32 @@ public abstract class AbstractFileBufferDocCreationTests {
 
 	@Test
 	public void testCreateDocumentPartipants_FileExt() {
-		assertParticipantsInvoked("anything.111foo", new Class[] {TestDSP1.class, TestDSP3.class});
+		assertParticipantsInvoked("anything.111foo", TestDSP1.class, TestDSP3.class);
 	}
 
 	@Test
 	public void testCreateDocumentPartipants_Name() {
-		assertParticipantsInvoked("111fooname", new Class[] {TestDSP2.class, TestDSP3.class});
+		assertParticipantsInvoked("111fooname", TestDSP2.class, TestDSP3.class);
 	}
 
 	@Test
 	public void testCreateDocumentPartipants_FileExt_Name() {
-		assertParticipantsInvoked("111fooname.111foo", new Class[] {TestDSP1.class, TestDSP2.class, TestDSP3.class});
+		assertParticipantsInvoked("111fooname.111foo", TestDSP1.class, TestDSP2.class, TestDSP3.class);
 	}
 
 	@Test
 	public void testCreateDocumentPartipants_FileExt_Extension() {
-		assertParticipantsInvoked("anything.222foo", new Class[] {TestDSP4.class, TestDSP6.class});
+		assertParticipantsInvoked("anything.222foo", TestDSP4.class, TestDSP6.class);
 	}
 
 	@Test
 	public void testCreateDocumentPartipants_Name_Extension() {
-		assertParticipantsInvoked("222fooname", new Class[] {TestDSP5.class, TestDSP6.class});
+		assertParticipantsInvoked("222fooname", TestDSP5.class, TestDSP6.class);
 	}
 
 	@Test
 	public void testCreateDocumentPartipants_FileExt_Name_Extension() {
-		assertParticipantsInvoked("222fooname.222foo", new Class[] {TestDSP4.class, TestDSP5.class, TestDSP6.class});
+		assertParticipantsInvoked("222fooname.222foo", TestDSP4.class, TestDSP5.class, TestDSP6.class);
 	}
 
 	@Test
@@ -119,7 +119,7 @@ public void testDocumentSetupParticipantExtension_3() {
 
 	/* Utilities */
 
-	private void assertParticipantsInvoked(String path, Class<?>[] expectedDSPsArray) {
+	private void assertParticipantsInvoked(String path, Class<?>... expectedDSPsArray) {
 		LocationKind[] lks= getSupportLocationKinds();
 		for (LocationKind lk : lks) {
 			IDocument document= fManager.createEmptyDocument(IPath.fromOSString(path), lk);
diff --git a/tests/org.eclipse.jface.tests/src/org/eclipse/jface/tests/viewers/TableViewerTest.java b/tests/org.eclipse.jface.tests/src/org/eclipse/jface/tests/viewers/TableViewerTest.java
@@ -1,5 +1,5 @@
 /*******************************************************************************
- * Copyright (c) 2000, 3034 IBM Corporation and others.
+ * Copyright (c) 2000, 2025 IBM Corporation and others.
  *
  * This program and the accompanying materials
  * are made available under the terms of the Eclipse Public License 2.0
@@ -96,7 +96,7 @@ protected StructuredViewer createViewer(Composite parent) {
 	ViewerColumn getViewerColumn(ColumnViewer viewer, int index) {
 		Method method;
 		try {
-			method = ColumnViewer.class.getDeclaredMethod("getViewerColumn", new Class[] { int.class });
+			method = ColumnViewer.class.getDeclaredMethod("getViewerColumn", int.class);
 			method.setAccessible(true);
 			return (ViewerColumn) method.invoke(viewer, Integer.valueOf(index));
 		} catch (Exception e) {

Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,5 @@`
`1`	`1`	`/*******************************************************************************`
`2`		`- * Copyright (c) 2006, 2015 IBM Corporation and others.`
	`2`	`+ * Copyright (c) 2006, 2025 IBM Corporation and others.`
`3`	`3`	`*`
`4`	`4`	`* This program and the accompanying materials`
`5`	`5`	`* are made available under the terms of the Eclipse Public License 2.0`
`@@ -53,7 +53,7 @@ public static Class<?>[] getTypeHierarchyFlattened(Class<?> type) {`
`53`	`53`	`classSearchOrderLookup = lookup = new HashMap<>();`
`54`	`54`	`lookup.put(type, classes);`
`55`	`55`	`}`
`56`		`- return classes.toArray(new Class[classes.size()]);`
	`56`	`+ return classes.toArray(Class[]::new);`
`57`	`57`	`}`
`58`	`58`
`59`	`59`	`/**`
Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,5 @@`
`1`	`1`	`/*`
`2`		`- * Copyright (C) 2005, 2015 db4objects Inc. http://www.db4o.com and others.`
	`2`	`+ * Copyright (C) 2005, 2025 db4objects Inc. http://www.db4o.com and others.`
`3`	`3`	`*`
`4`	`4`	`*`
`5`	`5`	`* This program and the accompanying materials`
`@@ -37,7 +37,7 @@ public IdentityConverter(Class<?> fromType, Class<?> toType) {`
`37`	`37`	`this.toType = toType;`
`38`	`38`	`}`
`39`	`39`
`40`		`- private Class<?>[][] primitiveMap = new Class[][] {`
	`40`	`+ private Class<?>[][] primitiveMap = {`
`41`	`41`	`{ Integer.TYPE, Integer.class }, { Short.TYPE, Short.class },`
`42`	`42`	`{ Long.TYPE, Long.class }, { Double.TYPE, Double.class },`
`43`	`43`	`{ Byte.TYPE, Byte.class }, { Float.TYPE, Float.class },`
Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,5 @@`
`1`	`1`	`/*******************************************************************************`
`2`		`- * Copyright (c) 2000, 2015 IBM Corporation and others.`
	`2`	`+ * Copyright (c) 2000, 2025 IBM Corporation and others.`
`3`	`3`	`*`
`4`	`4`	`* This program and the accompanying materials`
`5`	`5`	`* are made available under the terms of the Eclipse Public License 2.0`
`@@ -43,7 +43,7 @@ public IPath getPath(Object element) {`
`43`	`43`	`}`
`44`	`44`
`45`	`45`	`/** The list of provided adapters. */`
`46`		`- private static final Class<?>[] ADAPTER_LIST= new Class[] { ILocationProvider.class };`
	`46`	`+ private static final Class<?>[] ADAPTER_LIST = { ILocationProvider.class };`
`47`	`47`
`48`	`48`	`/** The provided location provider */`
`49`	`49`	`private ILocationProvider fLocationProvider= new LocationProvider();`
Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,5 @@`
`1`	`1`	`/*******************************************************************************`
`2`		`- * Copyright (c) 2006, 2015 The Pampered Chef and others.`
	`2`	`+ * Copyright (c) 2006, 2025 The Pampered Chef and others.`
`3`	`3`	`*`
`4`	`4`	`* This program and the accompanying materials`
`5`	`5`	`* are made available under the terms of the Eclipse Public License 2.0`
`@@ -32,14 +32,14 @@ public class ReflectedProperty {`
`32`	`32`	`*/`
`33`	`33`	`public ReflectedProperty(Object object, String propertyName) {`
`34`	`34`	`this.propertyName = propertyName;`
`35`		`- getter = new ReflectedMethod(object, makeGetterName(propertyName), new Class[] {});`
	`35`	`+ getter = new ReflectedMethod(object, makeGetterName(propertyName));`
`36`	`36`	`if (!getter.exists()) {`
`37`		`- getter = new ReflectedMethod(object, makeBooleanGetterName(propertyName), new Class[] {});`
	`37`	`+ getter = new ReflectedMethod(object, makeBooleanGetterName(propertyName));`
`38`	`38`	`if (!getter.exists()) {`
`39`	`39`	`throw new IllegalArgumentException("Cannot find getter for " + propertyName);`
`40`	`40`	`}`
`41`	`41`	`}`
`42`		`- setter = new ReflectedMethod(object, makeSetterName(propertyName), new Class[] { getter.getType() });`
	`42`	`+ setter = new ReflectedMethod(object, makeSetterName(propertyName), getter.getType());`
`43`	`43`	`}`
`44`	`44`
`45`	`45`	`private String makeBooleanGetterName(String propertyName) {`