Reducing the thickness of the highlight in selected tabs

mvm-sap · vogella · commit 066ac07a0bcf · 2024-07-25T09:57:30.000+02:00
diff --git a/bundles/org.eclipse.e4.ui.workbench.renderers.swt/src/org/eclipse/e4/ui/workbench/renderers/swt/CTabRendering.java b/bundles/org.eclipse.e4.ui.workbench.renderers.swt/src/org/eclipse/e4/ui/workbench/renderers/swt/CTabRendering.java
@@ -621,10 +621,12 @@ void drawSelectedTab(int itemIndex, GC gc, Rectangle bounds) {
 			if (onBottom) {
 				highlightOnTop = !highlightOnTop;
 			}
-			int verticalOffset = highlightOnTop ? 0 : bounds.height - 2;
+			int highlightHeight = 2;
+			int verticalOffset = highlightOnTop ? 0 : bounds.height - (highlightHeight - 1);
 			int horizontalOffset = itemIndex == 0 || cornerSize == SQUARE_CORNER ? 0 : 1;
 			int widthAdjustment = cornerSize == SQUARE_CORNER ? 0 : 1;
-			gc.fillRectangle(bounds.x + horizontalOffset, bounds.y + verticalOffset, bounds.width - widthAdjustment, 3);
+			gc.fillRectangle(bounds.x + horizontalOffset, bounds.y + verticalOffset, bounds.width - widthAdjustment,
+					highlightHeight);
 		}
 
 		if (backgroundPattern != null) {

Original file line number	Diff line number	Diff line change
`@@ -621,10 +621,12 @@ void drawSelectedTab(int itemIndex, GC gc, Rectangle bounds) {`
`621`	`621`	`if (onBottom) {`
`622`	`622`	`highlightOnTop = !highlightOnTop;`
`623`	`623`	`}`
`624`		`- int verticalOffset = highlightOnTop ? 0 : bounds.height - 2;`
	`624`	`+ int highlightHeight = 2;`
	`625`	`+ int verticalOffset = highlightOnTop ? 0 : bounds.height - (highlightHeight - 1);`
`625`	`626`	`int horizontalOffset = itemIndex == 0 \|\| cornerSize == SQUARE_CORNER ? 0 : 1;`
`626`	`627`	`int widthAdjustment = cornerSize == SQUARE_CORNER ? 0 : 1;`
`627`		`- gc.fillRectangle(bounds.x + horizontalOffset, bounds.y + verticalOffset, bounds.width - widthAdjustment, 3);`
	`628`	`+ gc.fillRectangle(bounds.x + horizontalOffset, bounds.y + verticalOffset, bounds.width - widthAdjustment,`
	`629`	`+ highlightHeight);`
`628`	`630`	`}`
`629`	`631`
`630`	`632`	`if (backgroundPattern != null) {`