Fix JUnit 5 assertion parameter order in navigator tests

JUnit 5 assertions require message parameter to be last, not first.
This commit fixes all occurrences where assertions were using the old
JUnit 4 style (message-first) to the correct JUnit 5 style (message-last).

Converted:
- assertEquals(message, expected, actual) → assertEquals(expected, actual, message)
- assertTrue(message, condition) → assertTrue(condition, message)
- assertFalse(message, condition) → assertFalse(condition, message)

Files fixed:
- WorkingSetTest.java
- JstPipelineTest.java
- FoldersAsProjectsContributionTest.java
- NestedResourcesTests.java
- PathComparatorTest.java
- ResourceMgmtActionProviderTests.java
- PipelineChainTest.java
- PipelineTest.java
- ProgrammaticOpenTest.java
- SorterTest.java
- M12Tests.java
- NavigatorTestBase.java
- OpenTest.java

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <[email protected]>

Author: vogella

tests/org.eclipse.ui.tests.navigator/src/org/eclipse/ui/tests/navigator/M12Tests.java

@@ -67,18 +67,18 @@ public void testM1ChildrenAreThere() throws Exception {
 		_expand(rootItems);
 		TreeItem p1Item = rootItems[_p1Ind];
 
-		assertEquals("P1 tree item should be an M1Project", M1Project.class,
-				p1Item.getData().getClass());
+		assertEquals(M1Project.class,
+				p1Item.getData().getClass(), "P1 tree item should be an M1Project");
 
 		TreeItem[] p1Children = p1Item.getItems();
 		_expand(p1Children);
 
 		TreeItem f1Child = _findChild("f1", p1Children);
-		assertNotNull("P1 should have a child named f1", f1Child);
+		assertNotNull(f1Child, "P1 should have a child named f1");
 
 		TreeItem[] f1Children = f1Child.getItems();
-		assertEquals("[bug #285353] f1 folder should have 2 children", 2,
-				f1Children.length);
+		assertEquals(2,
+				f1Children.length, "[bug #285353] f1 folder should have 2 children");
 	}
 
 	/** Test that when M2 is not active F1 has two children. */
@@ -100,10 +100,10 @@ public void testM1ChildrenAreThereWithoutM2() throws Exception {
 
 		TreeItem f1Child = _findChild("f1", p1Children);
 
-		assertNotNull("P1 should have a child named f1", f1Child);
+		assertNotNull(f1Child, "P1 should have a child named f1");
 
 		TreeItem[] f1Children = f1Child.getItems();
-		assertEquals("f1 folder should have 2 children", 2, f1Children.length);
+		assertEquals(2, f1Children.length, "f1 folder should have 2 children");
 	}
 
 	/** Tests that file2.txt in p2 is provided by M2 content provider. */
@@ -122,9 +122,9 @@ public void testM2Override() throws Exception {
 			DisplayHelper.sleep(10000000);
 
 		TreeItem file2Child = _findChild("file2.txt", p2Children);
-		assertNotNull("P2 should have a child named file2.txt", file2Child);
-		assertEquals("file2.txt should be provided by M2 content provider",
-				M2File.class, file2Child.getData().getClass());
+		assertNotNull(file2Child, "P2 should have a child named file2.txt");
+		assertEquals(M2File.class, file2Child.getData().getClass(),
+				"file2.txt should be provided by M2 content provider");
 
 	}
 
@@ -149,8 +149,8 @@ public void testInterceptAdd() throws CoreException {
 		TreeItem folder1Item = _findChild(NEW_FOLDER_1, rootItems[_p1Ind]
 				.getItems());
 
-		assertNotNull("M1 interceptAdd method should have been called",
-				folder1Item);
+		assertNotNull(folder1Item,
+				"M1 interceptAdd method should have been called");
 	}
 
 	/**
@@ -178,9 +178,8 @@ public void XXXtestInterceptRemove() throws CoreException {
 
 		newFolder1.delete(true, new NullProgressMonitor());
 		folder1Item = _findChild(NEW_FOLDER_1, rootItems[_p1Ind].getItems());
-		assertNull(
-				"[bug 285529] M1 interceptRemove method should have been called",
-				folder1Item);
+		assertNull(folder1Item,
+				"[bug 285529] M1 interceptRemove method should have been called");
 	}
 
 	/**
@@ -207,14 +206,12 @@ public void XXXtestInterceptRefreshOnChildTypeChange() throws CoreException {
 		M2ContentProvider.resetCounters();
 		ResourcesPlugin.getWorkspace().run(runnable, new NullProgressMonitor());
 
-		assertTrue(
-				"[bug 285529] M1 intercept update or refresh should have been called",
-				M1ContentProvider.getInterceptRefreshCount()
-						+ M1ContentProvider.getInterceptUpdateCount() >= 1);
-		assertTrue(
-				"[bug 285529] M2 intercept update or refresh should have been called",
-				M2ContentProvider.getInterceptRefreshCount()
-						+ M2ContentProvider.getInterceptUpdateCount() >= 1);
+		assertTrue(M1ContentProvider.getInterceptRefreshCount()
+						+ M1ContentProvider.getInterceptUpdateCount() >= 1,
+				"[bug 285529] M1 intercept update or refresh should have been called");
+		assertTrue(M2ContentProvider.getInterceptRefreshCount()
+						+ M2ContentProvider.getInterceptUpdateCount() >= 1,
+				"[bug 285529] M2 intercept update or refresh should have been called");
 	}
 
 }

tests/org.eclipse.ui.tests.navigator/src/org/eclipse/ui/tests/navigator/NavigatorTestBase.java

@@ -397,7 +397,7 @@ protected void checkItems(TreeItem[] rootItems, TestLabelProvider tlp, boolean a
 	 */
 	protected TreeItem _findChild(String name, TreeItem[] items) {
 		for (TreeItem item : items) {
-			assertTrue("Child " + item + " should be an M1 or M2 resource", item.getData() instanceof ResourceWrapper);
+			assertTrue(item.getData() instanceof ResourceWrapper, "Child " + item + " should be an M1 or M2 resource");
 			ResourceWrapper rw = (ResourceWrapper) item.getData();
 			if (name.equals(rw.getResource().getName())) {
 				return item;

tests/org.eclipse.ui.tests.navigator/src/org/eclipse/ui/tests/navigator/OpenTest.java

@@ -46,7 +46,7 @@ public void testNavigatorRootContents() throws Exception {
 
 		TreeItem[] items = _viewer.getTree().getItems();
 
-		assertTrue("There should be some items.", items.length > 0); //$NON-NLS-1$
+		assertTrue(items.length > 0, "There should be some items."); //$NON-NLS-1$
 
 		assertEquals(_project, items[_projectInd].getData());
 
@@ -74,15 +74,15 @@ public void testNavigatorExtensionEnablement() throws Exception {
 
 		TreeItem[] items = _viewer.getTree().getItems();
 
-		assertEquals("There should be NO items.", 0, items.length); //$NON-NLS-1$
+		assertEquals(0, items.length, "There should be NO items."); //$NON-NLS-1$
 
 		_contentService.getActivationService().deactivateExtensions(new String[] {}, true);
 
 		_viewer.expandToLevel(2);
 
 		items = _viewer.getTree().getItems();
 
-		assertTrue("There should be some items.", items.length > 0); //$NON-NLS-1$
+		assertTrue(items.length > 0, "There should be some items."); //$NON-NLS-1$
 
 	}
 

tests/org.eclipse.ui.tests.navigator/src/org/eclipse/ui/tests/navigator/PipelineTest.java

@@ -40,19 +40,17 @@ public PipelineTest() {
 	@Test
 	public void testNavigatorResourceJava() throws Exception {
 
-		assertEquals(
-				"There should be no visible extensions for the pipeline viewer.",
-				0, _contentService.getVisibleExtensionIds().length);
+		assertEquals(0, _contentService.getVisibleExtensionIds().length,
+				"There should be no visible extensions for the pipeline viewer.");
 
 		_contentService.bindExtensions(new String[] {
 				COMMON_NAVIGATOR_RESOURCE_EXT, COMMON_NAVIGATOR_JAVA_EXT },
 				false);
 
 		// Note this test will fail showing only one if the JDT stuff
 		// is not included in the executing bundles (which it normally is)
-		assertEquals(
-				"There should be two visible extensions for the pipeline viewer.",
-				2, _contentService.getVisibleExtensionIds().length);
+		assertEquals(2, _contentService.getVisibleExtensionIds().length,
+				"There should be two visible extensions for the pipeline viewer.");
 
 		_contentService.getActivationService().activateExtensions(
 				new String[] { COMMON_NAVIGATOR_RESOURCE_EXT,
@@ -66,11 +64,11 @@ public void testNavigatorResourceJava() throws Exception {
 
 		TreeItem[] rootItems = _viewer.getTree().getItems();
 
-		assertEquals(
-				"There should be " + _projectCount + " item(s).", _projectCount, rootItems.length); //$NON-NLS-1$
+		assertEquals(_projectCount, rootItems.length,
+				"There should be " + _projectCount + " item(s)."); //$NON-NLS-1$
 
-		assertTrue(
-				"The root object should be an IJavaProject, which is IAdaptable.", rootItems[0].getData() instanceof IAdaptable); //$NON-NLS-1$
+		assertTrue(rootItems[0].getData() instanceof IAdaptable,
+				"The root object should be an IJavaProject, which is IAdaptable."); //$NON-NLS-1$
 
 		IProject adaptedProject = ((IAdaptable) rootItems[_projectInd]
 				.getData()).getAdapter(IProject.class);
@@ -81,7 +79,7 @@ public void testNavigatorResourceJava() throws Exception {
 
 		TreeItem[] projectChildren = rootItems[_projectInd].getItems();
 
-		assertTrue("There should be some items.", projectChildren.length > 0); //$NON-NLS-1$
+		assertTrue(projectChildren.length > 0, "There should be some items."); //$NON-NLS-1$
 		for (TreeItem projectChild : projectChildren) {
 			if (projectChild.getData() == sourceFolder) {
 				fail("The src folder should not be added as an IFolder.");
@@ -95,8 +93,8 @@ public void testNavigatorResourceJava() throws Exception {
 
 		rootItems = _viewer.getTree().getItems();
 
-		assertEquals("There should be " + (_projectCount + 1) + " items.",
-				_projectCount + 1, rootItems.length);
+		assertEquals(_projectCount + 1, rootItems.length,
+				"There should be " + (_projectCount + 1) + " items.");
 
 		boolean found = false;
 		for (int i = 0; i < rootItems.length && !found; i++) {