Skip to content

Commit 09e619d

Browse files
committed
Code review feedback change: code style changes, delete unintended test class inclusion, fix copyright headers.
1 parent 04afd45 commit 09e619d

File tree

3 files changed

+25
-91
lines changed

3 files changed

+25
-91
lines changed

tests/org.eclipse.e4.ui.tests/src/org/eclipse/e4/ui/tests/application/CloseActiveEditorsTest.java

Lines changed: 0 additions & 64 deletions
This file was deleted.

tests/org.eclipse.ui.tests/Eclipse UI Tests/org/eclipse/ui/tests/e4/CloseAllHandlerTest.java

Lines changed: 15 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,15 @@
1+
/*******************************************************************************
2+
* Copyright (c) 2024 Feilim Breatnach and others.
3+
*
4+
* This program and the accompanying materials are made available under the
5+
* terms of the Eclipse Public License 2.0 which accompanies this distribution,
6+
* and is available at https://www.eclipse.org/legal/epl-2.0/
7+
*
8+
* SPDX-License-Identifier: EPL-2.0
9+
*
10+
* Contributors: Feilim Breatnach, Pilz Ireland - PR #2360
11+
*******************************************************************************/
12+
113
package org.eclipse.ui.tests.e4;
214

315
import java.util.Collections;
@@ -40,8 +52,8 @@
4052
import org.osgi.framework.ServiceReference;
4153

4254
/**
43-
* @since 3.5
44-
*
55+
* Tests the enabled when and execution logic within the
56+
* {@link CloseAllHandler}.
4557
*/
4658
public class CloseAllHandlerTest {
4759

@@ -69,27 +81,19 @@ private MApplication getApplicationModel() {
6981
}
7082

7183
/**
72-
* <p>
7384
* Tests the enabled when and execution logic within the
7485
* {@link CloseAllHandler}.
75-
* </p>
7686
*
77-
* <p>
7887
* Scenario 1: E4 style part contribution which is tagged as representing an
7988
* 'editor' is closed via the handler (and the enablement of handler is
8089
* checked).
81-
* </p>
8290
*
83-
* <p>
8491
* Scenario 2: compatibility layer type editor is closed via the handler (and
8592
* the enablement of handler is checked).
86-
* </p>
8793
*
88-
* <p>
8994
* Scenario 3: a mix of an open compatibility layer type editor *and* an E4
9095
* style part contribution which is tagged as representing an 'editor' are both
9196
* closed via the handler (and the enablement of handler is checked).
92-
* </p>
9397
*/
9498
@Test
9599
public void testCloseMixedEditorTypes() {
@@ -270,13 +274,9 @@ public IFile getFile() {
270274
return null;
271275
}
272276

273-
/**
274-
* {@inheritDoc}
275-
*/
276277
@Override
277278
public IStorage getStorage() {
278279
return null;
279280
}
280281
}
281-
282-
}
282+
}

tests/org.eclipse.ui.tests/Eclipse UI Tests/org/eclipse/ui/tests/e4/DummyEditor.java

Lines changed: 10 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,14 @@
11
/*******************************************************************************
2-
* Copyright (c) 2010 IBM Corporation and others.
3-
*
4-
* This program and the accompanying materials
5-
* are made available under the terms of the Eclipse Public License 2.0
6-
* which accompanies this distribution, and is available at
7-
* https://www.eclipse.org/legal/epl-2.0/
8-
*
9-
* SPDX-License-Identifier: EPL-2.0
10-
*
11-
* Contributors:
12-
* IBM Corporation - initial API and implementation
13-
******************************************************************************/
2+
* Copyright (c) 2024 Feilim Breatnach and others.
3+
*
4+
* This program and the accompanying materials are made available under the
5+
* terms of the Eclipse Public License 2.0 which accompanies this distribution,
6+
* and is available at https://www.eclipse.org/legal/epl-2.0/
7+
*
8+
* SPDX-License-Identifier: EPL-2.0
9+
*
10+
* Contributors: Feilim Breatnach, Pilz Ireland - PR #2360
11+
*******************************************************************************/
1412

1513
package org.eclipse.ui.tests.e4;
1614

0 commit comments

Comments
 (0)