Migrate PluginWalkerTest from JUnit 4 to JUnit 5 in

org.eclipse.ui.tests.pluginchecks

Author: vogella

tests/org.eclipse.ui.tests.pluginchecks/META-INF/MANIFEST.MF

@@ -5,8 +5,7 @@ Bundle-SymbolicName: org.eclipse.ui.tests.pluginchecks;singleton:=true
 Bundle-Version: 1.2.400.qualifier
 Automatic-Module-Name: org.eclipse.ui.tests.pluginchecks
 Bundle-RequiredExecutionEnvironment: JavaSE-17
-Require-Bundle: org.junit;bundle-version="4.12.0",
- org.eclipse.core.runtime;bundle-version="3.29.0",
+Require-Bundle: org.eclipse.core.runtime;bundle-version="3.29.0",
  org.eclipse.e4.ui.css.swt;bundle-version="0.13.200",
  org.eclipse.e4.ui.model.workbench;bundle-version="2.1.100",
  org.eclipse.e4.ui.workbench.swt;bundle-version="0.14.300",
@@ -28,4 +27,6 @@ Require-Bundle: org.junit;bundle-version="4.12.0",
  org.eclipse.ui.monitoring;bundle-version="1.1.300"
 Bundle-ActivationPolicy: lazy
 Bundle-Vendor: Eclipse.org
-Import-Package: org.eclipse.ui.internal
+Import-Package: org.eclipse.ui.internal,
+ org.junit.jupiter.api;version="[5.14.0,6.0.0)",
+ org.junit.jupiter.api.function;version="[5.14.0,6.0.0)"

tests/org.eclipse.ui.tests.pluginchecks/src/org/eclipse/ui/tests/pluginchecks/PluginWalkerTest.java

@@ -14,9 +14,9 @@
 
 package org.eclipse.ui.tests.pluginchecks;
 
-import static org.junit.Assert.assertNotNull;
-import static org.junit.Assert.assertTrue;
-import static org.junit.Assert.fail;
+import static org.junit.jupiter.api.Assertions.assertNotNull;
+import static org.junit.jupiter.api.Assertions.assertTrue;
+import static org.junit.jupiter.api.Assertions.fail;
 
 import java.io.IOException;
 import java.io.InputStream;
@@ -37,8 +37,8 @@
 import org.eclipse.core.runtime.IExtensionPoint;
 import org.eclipse.core.runtime.IExtensionRegistry;
 import org.eclipse.core.runtime.RegistryFactory;
-import org.junit.Before;
-import org.junit.Test;
+import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.Test;
 import org.osgi.framework.Bundle;
 import org.osgi.framework.BundleContext;
 import org.osgi.framework.Constants;
@@ -66,10 +66,10 @@ public class PluginWalkerTest {
 	private BundleContext bundleContext;
 	private List<String> bundlesWithPluginXml;
 
-	@Before
+	@BeforeEach
 	public void setup() throws Exception {
 		Bundle bundle = FrameworkUtil.getBundle(PluginWalkerTest.class);
-		assertNotNull("Make sure you're running this as a plugin test", bundle);
+		assertNotNull(bundle, "Make sure you're running this as a plugin test");
 		assertNotNull(bundle);
 		bundleContext = bundle.getBundleContext();
 		bundlesWithPluginXml = List.of("org.eclipse.e4.ui.css.swt", "org.eclipse.e4.ui.model.workbench",
@@ -101,10 +101,8 @@ public void ensurePluginxmlContainsAtLeastOneEntry() throws Exception {
 			boolean hasExtension = extensions.getLength() > 0;
 			boolean hasExtensionPoint = extensionpoint.getLength() > 0;
 
-			assertTrue(
-					"plugin.xml from " + bundleSymbolicName
-							+ "  must contain at least one extension point or extension",
-					hasExtension || hasExtensionPoint);
+			assertTrue(hasExtension || hasExtensionPoint, "plugin.xml from " + bundleSymbolicName
+					+ "  must contain at least one extension point or extension");
 		}
 
 	}