Call methods directly instead of using reflection in genericeditor

akurtakov · akurtakov · commit 112c0bf8fa2c · 2025-08-15T17:13:07.000+03:00
diff --git a/tests/org.eclipse.ui.genericeditor.tests/src/org/eclipse/ui/genericeditor/tests/HoverTest.java b/tests/org.eclipse.ui.genericeditor.tests/src/org/eclipse/ui/genericeditor/tests/HoverTest.java
@@ -170,7 +170,7 @@ private Shell getHoverShell(AbstractInformationControlManager manager, boolean f
 				return null;
 			}
 		}
-		Shell shell= (Shell) new Accessor(control[0], AbstractInformationControl.class).get("fShell");
+		Shell shell= control[0].getShell();
 		DisplayHelper.waitForCondition(this.editor.getSite().getShell().getDisplay(), 2000, () -> shell.isVisible());
 		if (failOnError) {
 			assertTrue(shell.isVisible());
diff --git a/tests/org.eclipse.ui.genericeditor.tests/src/org/eclipse/ui/genericeditor/tests/ShowInformationTest.java b/tests/org.eclipse.ui.genericeditor.tests/src/org/eclipse/ui/genericeditor/tests/ShowInformationTest.java
@@ -83,7 +83,7 @@ private Shell getHoverShell(AbstractInformationControlManager manager, boolean f
 			}
 		}
 		boolean[] result = {false};
-		Shell shell= (Shell) new Accessor(control[0], AbstractInformationControl.class).get("fShell");
+		Shell shell= control[0].getShell();
 		DisplayHelper.waitForCondition(control[0].getShell().getDisplay(), 2000, () -> result[0] = shell.isVisible());
 		if (failOnError) {
 			assertTrue(shell.isVisible());

Original file line number	Diff line number	Diff line change
`@@ -170,7 +170,7 @@ private Shell getHoverShell(AbstractInformationControlManager manager, boolean f`
`170`	`170`	`return null;`
`171`	`171`	`}`
`172`	`172`	`}`
`173`		`- Shell shell= (Shell) new Accessor(control[0], AbstractInformationControl.class).get("fShell");`
	`173`	`+ Shell shell= control[0].getShell();`
`174`	`174`	`DisplayHelper.waitForCondition(this.editor.getSite().getShell().getDisplay(), 2000, () -> shell.isVisible());`
`175`	`175`	`if (failOnError) {`
`176`	`176`	`assertTrue(shell.isVisible());`
Original file line number	Diff line number	Diff line change
`@@ -83,7 +83,7 @@ private Shell getHoverShell(AbstractInformationControlManager manager, boolean f`
`83`	`83`	`}`
`84`	`84`	`}`
`85`	`85`	`boolean[] result = {false};`
`86`		`- Shell shell= (Shell) new Accessor(control[0], AbstractInformationControl.class).get("fShell");`
	`86`	`+ Shell shell= control[0].getShell();`
`87`	`87`	`DisplayHelper.waitForCondition(control[0].getShell().getDisplay(), 2000, () -> result[0] = shell.isVisible());`
`88`	`88`	`if (failOnError) {`
`89`	`89`	`assertTrue(shell.isVisible());`