Remove IPropertyChangeListener registration in dispose method of editor

Author: tobias-melcher

bundles/org.eclipse.ui.workbench/eclipseui/org/eclipse/ui/part/EditorPart.java

@@ -291,4 +291,12 @@ protected final void checkSite(IWorkbenchPartSite site) {
 		Assert.isTrue(site instanceof IEditorSite, "The site for an editor must be an IEditorSite"); //$NON-NLS-1$
 	}
 
+	@Override
+	public void dispose() {
+		if (compatibilityTitleListener != null) {
+			removePropertyListener(compatibilityTitleListener);
+			compatibilityTitleListener = null;
+		}
+		super.dispose();
+	}
 }

bundles/org.eclipse.ui.workbench/eclipseui/org/eclipse/ui/part/MultiPageEditorPart.java

@@ -153,18 +153,21 @@ public abstract class MultiPageEditorPart extends EditorPart implements IPageCha
 
 	private ListenerList<IPageChangedListener> pageChangeListeners = new ListenerList<>(ListenerList.IDENTITY);
 
+	private org.eclipse.jface.util.IPropertyChangeListener propertyChangeListenerToUpdateContainer;
+
 	/**
 	 * Creates an empty multi-page editor with no pages and registers a
 	 * {@link PropertyChangeListener} to listen for changes to the editor's
 	 * preference..
 	 */
 	protected MultiPageEditorPart() {
 		super();
-		getAPIPreferenceStore().addPropertyChangeListener(event -> {
+		propertyChangeListenerToUpdateContainer = event -> {
 			if (isUpdateRequired(event)) {
 				updateContainer();
 			}
-		});
+		};
+		getAPIPreferenceStore().addPropertyChangeListener(propertyChangeListenerToUpdateContainer);
 	}
 
 	/**
@@ -526,6 +529,11 @@ protected IEditorSite createSite(IEditorPart editor) {
 	 */
 	@Override
 	public void dispose() {
+		IPreferenceStore store = getAPIPreferenceStore();
+		if (propertyChangeListenerToUpdateContainer != null) {
+			store.removePropertyChangeListener(propertyChangeListenerToUpdateContainer);
+			propertyChangeListenerToUpdateContainer = null;
+		}
 		if (getSite() != null) {
 			deactivateSite(true, false);
 		}