Apply search results viewer limit to all levels of tree children.

Currently viewer limit is applied to top level elements. Object[]
getChildren(Object parentElement) missing limit application.

see #2279

Author: raghucssit

bundles/org.eclipse.search/newsearch/org/eclipse/search2/internal/ui/SearchMessages.properties

@@ -84,7 +84,7 @@ OpenSearchPreferencesAction_label=Preferences...
 OpenSearchPreferencesAction_tooltip=Open Search Preference Page
 MatchFilterSelectionDialog_filter_description=Select the &matches to exclude from the search results:
 MatchFilterSelectionDialog_description_label=Filter description:
-MatchFilterSelectionDialog_limit_description=&Limit number of top level elements to:
+MatchFilterSelectionDialog_limit_description=&Limit number of elements per level to:
 MatchFilterSelectionDialog_label=Search Filters
 MatchFilterSelectionDialog_error_invalid_limit=Element limit must be a positive number.
 MatchFilterSelectionAction_label=&Filters...

bundles/org.eclipse.search/search/org/eclipse/search/internal/ui/text/FileTreeContentProvider.java

@@ -56,14 +56,7 @@ public class FileTreeContentProvider implements ITreeContentProvider, IFileSearc
 
 	@Override
 	public Object[] getElements(Object inputElement) {
-		Object[] children= getChildren(inputElement);
-		int elementLimit= getElementLimit();
-		if (elementLimit != -1 && elementLimit < children.length) {
-			Object[] limitedChildren= new Object[elementLimit];
-			System.arraycopy(children, 0, limitedChildren, 0, elementLimit);
-			return limitedChildren;
-		}
-		return children;
+		return getChildren(inputElement);
 	}
 
 	private int getElementLimit() {
@@ -202,6 +195,14 @@ public Object[] getChildren(Object parentElement) {
 		Set<Object> children= fChildrenMap.get(parentElement);
 		if (children == null)
 			return EMPTY_ARR;
+
+		int elementLimit = getElementLimit();
+		if (elementLimit != -1 && elementLimit < children.size()) {
+			Object[] limitedChildren = new Object[elementLimit];
+			System.arraycopy(children.toArray(), 0, limitedChildren, 0, elementLimit);
+			return limitedChildren;
+		}
+
 		return children.toArray();
 	}