Adding experimental preference to enable update on runtime behavior

In the UI Preferences -> General -> Appearance, there is a new HiDpi
setting that could be checked to enable the HiDpi behavior. This check
will also enable Edge browser by default instead of Internet explorer.
This is an experimental feature to test the HiDpi stuff before it is
actually released and set by default. For now, this preference is
disabled by default.

Author: ShahzaibIbrahim

bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/IWorkbenchPreferenceConstants.java

@@ -705,4 +705,13 @@ public interface IWorkbenchPreferenceConstants {
 	 * @since 3.130
 	 */
 	String LARGE_VIEW_LIMIT = "largeViewLimit"; //$NON-NLS-1$
+
+	/**
+	 * <p>
+	 * Whether the UI updates on runtime during dpi change
+	 * </p>
+	 *
+	 * @since 3.133
+	 */
+	String UPDATE_ON_RUNTIME_KEY = "UPDATE_ON_RUNTIME_KEY"; //$NON-NLS-1$
 }

bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/Workbench.java

@@ -562,7 +562,7 @@ public static int createAndRunWorkbench(final Display display, final WorkbenchAd
 				int orientation = store.getInt(IPreferenceConstants.LAYOUT_DIRECTION);
 				Window.setDefaultOrientation(orientation);
 			}
-
+			setRuntimePropertyFromPreference(display);
 			if (obj instanceof E4Application) {
 				E4Application e4app = (E4Application) obj;
 				E4Workbench e4Workbench = e4app.createE4Workbench(getApplicationContext(), display);
@@ -656,6 +656,17 @@ public void update() {
 		return returnCode[0];
 	}
 
+	private static void setRuntimePropertyFromPreference(final Display display) {
+		boolean updateOnRunTime = PrefUtil.getAPIPreferenceStore()
+				.getBoolean(IWorkbenchPreferenceConstants.UPDATE_ON_RUNTIME_KEY);
+		display.setRescalingAtRuntime(updateOnRunTime);
+		if (updateOnRunTime) {
+			System.setProperty("org.eclipse.swt.browser.DefaultType", "edge"); //$NON-NLS-1$ //$NON-NLS-2$
+		} else {
+			System.setProperty("org.eclipse.swt.browser.DefaultType", "ie"); //$NON-NLS-1$ //$NON-NLS-2$
+		}
+	}
+
 	private static void setSearchContribution(MApplication app, boolean enabled) {
 		for (MTrimContribution contribution : app.getTrimContributions()) {
 			if ("org.eclipse.ui.ide.application.trimcontribution.QuickAccess".contains(contribution //$NON-NLS-1$

bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/WorkbenchMessages.java

@@ -34,6 +34,8 @@ public class WorkbenchMessages extends NLS {
 
 	public static String ThemingEnabled;
 
+	public static String UpdateUIZoomTitle;
+
 	public static String ThemeChangeWarningText;
 
 	public static String ThemeChangeWarningTitle;

bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/dialogs/ViewsPreferencePage.java

@@ -37,6 +37,7 @@
 import org.eclipse.core.runtime.IExtensionPoint;
 import org.eclipse.core.runtime.IExtensionRegistry;
 import org.eclipse.core.runtime.Platform;
+import org.eclipse.core.runtime.Platform.OS;
 import org.eclipse.core.runtime.RegistryFactory;
 import org.eclipse.core.runtime.preferences.DefaultScope;
 import org.eclipse.core.runtime.preferences.IEclipsePreferences;
@@ -73,6 +74,7 @@
 import org.eclipse.swt.widgets.Composite;
 import org.eclipse.swt.widgets.Control;
 import org.eclipse.swt.widgets.Display;
+import org.eclipse.swt.widgets.Group;
 import org.eclipse.swt.widgets.Label;
 import org.eclipse.ui.IWorkbench;
 import org.eclipse.ui.IWorkbenchPreferenceConstants;
@@ -114,6 +116,9 @@ public class ViewsPreferencePage extends PreferencePage implements IWorkbenchPre
 	private boolean highContrastMode;
 
 	private Button themingEnabled;
+	private Button updateOnRunTime;
+	boolean initialStateUpdateOnRuntime = PrefUtil.getAPIPreferenceStore()
+			.getBoolean(IWorkbenchPreferenceConstants.UPDATE_ON_RUNTIME_KEY);
 
 	private Button hideIconsForViewTabs;
 	private Button showFullTextForViewTabs;
@@ -135,6 +140,7 @@ protected Control createContents(Composite parent) {
 			layout.horizontalSpacing = 10;
 			comp.setLayout(layout);
 			createThemeIndependentComposits(comp);
+			createUpdateOnRuntimeButton(comp);
 			return comp;
 		}
 
@@ -180,6 +186,8 @@ protected Control createContents(Composite parent) {
 		createHideIconsForViewTabs(comp);
 		createDependency(showFullTextForViewTabs, hideIconsForViewTabs);
 
+		createUpdateOnRuntimeButton(comp);
+
 		if (currentTheme != null) {
 			String colorsAndFontsThemeId = getColorAndFontThemeIdByThemeId(currentTheme.getId());
 			if (colorsAndFontsThemeId != null && !currentColorsAndFontsTheme.getId().equals(colorsAndFontsThemeId)) {
@@ -192,6 +200,32 @@ protected Control createContents(Composite parent) {
 		return comp;
 	}
 
+	private void createUpdateOnRuntimeButton(Composite composite) {
+		if (!OS.isWindows()) {
+			return;
+		}
+		createLabel(composite, ""); //$NON-NLS-1$
+		Group buttonComposite = new Group(composite, SWT.LEFT);
+		buttonComposite.setText("HiDPI settings"); //$NON-NLS-1$
+
+		GridData gridData = new GridData(SWT.FILL, SWT.CENTER, true, false);
+		gridData.horizontalSpan = ((GridLayout) composite.getLayout()).numColumns;
+		buttonComposite.setLayoutData(gridData);
+		buttonComposite.setFont(composite.getFont());
+		GridLayout layout = new GridLayout(1, false);
+		buttonComposite.setLayout(layout);
+		Label infoLabel = new Label(buttonComposite, SWT.WRAP);
+		infoLabel.setText(
+				"This preference is Windows only. Activating it will change the DPI awareness of the IDE to PerMonitorV2 and dynamically scale all windows according to the monitor it is currently assigned to. An additional effect of this preference is to set the default browser to Edge to provide the appropriate scaling of content displayed in a browser. This feature is still in development and therefore marked as experimental."); //$NON-NLS-1$
+		GridData labelGridData = new GridData(SWT.FILL, SWT.CENTER, true, false);
+		labelGridData.widthHint = 400; // Adjust this value to control initial wrapping width
+		infoLabel.setLayoutData(labelGridData);
+		createLabel(buttonComposite, ""); //$NON-NLS-1$
+
+		updateOnRunTime = createCheckButton(buttonComposite, WorkbenchMessages.UpdateUIZoomTitle,
+				initialStateUpdateOnRuntime);
+	}
+
 	private void createThemeIndependentComposits(Composite comp) {
 		createUseRoundTabs(comp);
 		createColoredLabelsPref(comp);
@@ -212,6 +246,9 @@ protected void createHideIconsForViewTabs(Composite composite) {
 				CTabRendering.HIDE_ICONS_FOR_VIEW_TABS_DEFAULT);
 		hideIconsForViewTabs = createCheckButton(composite, WorkbenchMessages.ViewsPreference_hideIconsForViewTabs,
 				actualValue);
+		GridData gridData = new GridData();
+		gridData.horizontalIndent = 20;
+		hideIconsForViewTabs.setLayoutData(gridData);
 	}
 
 	private boolean getSwtRendererPreference(String prefName, boolean defaultValue) {
@@ -224,10 +261,6 @@ private boolean getSwtRendererPreference(String prefName, boolean defaultValue)
 	 * @param hideIconsForViewTabs
 	 */
 	private void createDependency(Button parent, Button dependent) {
-		GridData gridData = new GridData();
-		gridData.horizontalIndent = 20;
-		dependent.setLayoutData(gridData);
-
 		boolean parentState = parent.getSelection();
 		dependent.setEnabled(parentState);
 
@@ -341,6 +374,11 @@ public boolean performOk() {
 				.getSelection();
 		prefs.putBoolean(PartRenderingEngine.ENABLED_THEME_KEY, themingEnabled.getSelection());
 
+		boolean isUpdateOnRuntTmeChanged = (updateOnRunTime != null
+				&& initialStateUpdateOnRuntime != updateOnRunTime.getSelection());
+		apiStore.setValue(IWorkbenchPreferenceConstants.UPDATE_ON_RUNTIME_KEY,
+				updateOnRunTime == null ? false : updateOnRunTime.getSelection());
+
 		prefs.putBoolean(CTabRendering.USE_ROUND_TABS, useRoundTabs.getSelection());
 		try {
 			prefs.flush();
@@ -373,13 +411,19 @@ public boolean performOk() {
 		if (themingEnabledChanged) {
 			showRestartDialog();
 		}
+		if (isUpdateOnRuntTmeChanged) {
+			showRestartDialog("DPI Setting Changed", "Restart for the effect to take place"); //$NON-NLS-1$ //$NON-NLS-2$
+		}
 
 		return super.performOk();
 	}
 
 	private void showRestartDialog() {
-		if (new MessageDialog(null, WorkbenchMessages.ThemeChangeWarningTitle, null,
-				WorkbenchMessages.ThemeChangeWarningText, MessageDialog.NONE, 2,
+		showRestartDialog(WorkbenchMessages.ThemeChangeWarningTitle, WorkbenchMessages.ThemeChangeWarningText);
+	}
+
+	private void showRestartDialog(String title, String warningText) {
+		if (new MessageDialog(null, title, null, warningText, MessageDialog.NONE, 2,
 				WorkbenchMessages.Workbench_RestartButton, WorkbenchMessages.Workbench_DontRestartButton)
 						.open() == Window.OK) {
 			Display.getDefault().asyncExec(() -> PlatformUI.getWorkbench().restart());

bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/messages.properties

@@ -497,6 +497,7 @@ PreferencePageParameterValues_pageLabelSeparator = \ >\
 ThemingEnabled = E&nable theming
 ThemeChangeWarningText = Restart for the theme changes to take full effect
 ThemeChangeWarningTitle = Theme Changed
+UpdateUIZoomTitle = Update UI scaling on runtime
 # --- Workbench -----
 WorkbenchPreference_openMode=Open mode
 WorkbenchPreference_doubleClick=D&ouble click