Skip to content

Commit 40552f3

Browse files
akurtakovakurtakov
committed
Remove IPageLayout.addFastView
Deprecated for years and the only implementation is actually doing nothing but logging "unsupported ..."
1 parent a614e30 commit 40552f3

File tree

4 files changed

+18
-66
lines changed

4 files changed

+18
-66
lines changed

‎bundles/org.eclipse.ui.workbench/.settings/.api_filters‎

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -88,6 +88,20 @@
8888
</message_arguments>
8989
</filter>
9090
</resource>
91+
<resource path="eclipseui/org/eclipse/ui/IPageLayout.java" type="org.eclipse.ui.IPageLayout">
92+
<filter comment="https://github.com/eclipse-platform/eclipse.platform.ui/pull/3606" id="405901410">
93+
<message_arguments>
94+
<message_argument value="org.eclipse.ui.IPageLayout"/>
95+
<message_argument value="addFastView(String)"/>
96+
</message_arguments>
97+
</filter>
98+
<filter comment="https://github.com/eclipse-platform/eclipse.platform.ui/pull/3606" id="405901410">
99+
<message_arguments>
100+
<message_argument value="org.eclipse.ui.IPageLayout"/>
101+
<message_argument value="addFastView(String, float)"/>
102+
</message_arguments>
103+
</filter>
104+
</resource>
91105
<resource path="eclipseui/org/eclipse/ui/dialogs/YesNoCancelListSelectionDialog.java" type="org.eclipse.ui.dialogs.YesNoCancelListSelectionDialog">
92106
<filter id="576778288">
93107
<message_arguments>

‎bundles/org.eclipse.ui.workbench/eclipseui/org/eclipse/ui/IPageLayout.java‎

Lines changed: 1 addition & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/*******************************************************************************
2-
* Copyright (c) 2000, 2019 IBM Corporation and others.
2+
* Copyright (c) 2000, 2025 IBM Corporation and others.
33
*
44
* This program and the accompanying materials
55
* are made available under the terms of the Eclipse Public License 2.0
@@ -215,34 +215,6 @@ public interface IPageLayout {
215215
*/
216216
void addActionSet(String actionSetId);
217217

218-
/**
219-
* Adds the view with the given compound id to the page layout as a fast view.
220-
* See the {@link IPageLayout} type documentation for more details about
221-
* compound ids. The primary id must name a view contributed to the workbench's
222-
* view extension point (named <code>"org.eclipse.ui.views"</code>).
223-
*
224-
* @param viewId the compound id of the view to be added
225-
* @since 2.0
226-
* @deprecated discontinued support for fast views
227-
*/
228-
@Deprecated(forRemoval = true, since = "2023-12")
229-
void addFastView(String viewId);
230-
231-
/**
232-
* Adds the view with the given compound id to the page layout as a fast view
233-
* with the given width ratio. See the {@link IPageLayout} type documentation
234-
* for more details about compound ids. The primary id must name a view
235-
* contributed to the workbench's view extension point (named
236-
* <code>"org.eclipse.ui.views"</code>).
237-
*
238-
* @param viewId the compound id of the view to be added
239-
* @param ratio the percentage of the workbench the fast view will cover
240-
* @since 2.0
241-
* @deprecated discontinued support for fast views
242-
*/
243-
@Deprecated(forRemoval = true, since = "2023-12")
244-
void addFastView(String viewId, float ratio);
245-
246218
/**
247219
* Adds a new wizard shortcut to the page layout. These are typically shown in
248220
* the UI to allow rapid navigation to appropriate new wizards. For example, in

‎bundles/org.eclipse.ui.workbench/eclipseui/org/eclipse/ui/internal/PerspectiveExtensionReader.java‎

Lines changed: 2 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/*******************************************************************************
2-
* Copyright (c) 2013, 2018 IBM Corporation and others.
2+
* Copyright (c) 2013, 2025 IBM Corporation and others.
33
*
44
* This program and the accompanying materials
55
* are made available under the terms of the Eclipse Public License 2.0
@@ -52,8 +52,6 @@ public class PerspectiveExtensionReader extends RegistryReader {
5252

5353
private static final String VAL_STACK = "stack";//$NON-NLS-1$
5454

55-
private static final String VAL_FAST = "fast";//$NON-NLS-1$
56-
5755
private static final String VAL_TRUE = "true";//$NON-NLS-1$
5856

5957
// VAL_FALSE added by [email protected]
@@ -252,7 +250,7 @@ private boolean processView(IConfigurationElement element) {
252250
logMissingAttribute(element, IWorkbenchRegistryConstants.ATT_RELATIONSHIP);
253251
return false;
254252
}
255-
if (!VAL_FAST.equals(relationship) && relative == null) {
253+
if (relative == null) {
256254
logError(element, "Attribute '" + IWorkbenchRegistryConstants.ATT_RELATIVE //$NON-NLS-1$
257255
+ "' not defined. This attribute is required when " //$NON-NLS-1$
258256
+ IWorkbenchRegistryConstants.ATT_RELATIONSHIP + "=\"" + relationship + "\"."); //$NON-NLS-1$ //$NON-NLS-2$
@@ -277,7 +275,6 @@ private boolean processView(IConfigurationElement element) {
277275
// Get relationship details.
278276
boolean stack = false;
279277
int intRelation = 0;
280-
boolean fast = false;
281278
switch (relationship) {
282279
case VAL_LEFT:
283280
intRelation = IPageLayout.LEFT;
@@ -294,9 +291,6 @@ private boolean processView(IConfigurationElement element) {
294291
case VAL_STACK:
295292
stack = true;
296293
break;
297-
case VAL_FAST:
298-
fast = true;
299-
break;
300294
default:
301295
return false;
302296
}
@@ -315,15 +309,6 @@ private boolean processView(IConfigurationElement element) {
315309
} else {
316310
pageLayout.stackView(id, relative, false);
317311
}
318-
}
319-
// If the view is a fast view...
320-
else if (fast) {
321-
if (ratio == IPageLayout.NULL_RATIO) {
322-
// The ratio has not been specified.
323-
pageLayout.addFastView(id);
324-
} else {
325-
pageLayout.addFastView(id, ratio);
326-
}
327312
} else {
328313

329314
// The view is a regular view.

‎bundles/org.eclipse.ui.workbench/eclipseui/org/eclipse/ui/internal/e4/compatibility/ModeledPageLayout.java‎

Lines changed: 1 addition & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/*******************************************************************************
2-
* Copyright (c) 2009, 2016 IBM Corporation and others.
2+
* Copyright (c) 2009, 2025 IBM Corporation and others.
33
*
44
* This program and the accompanying materials
55
* are made available under the terms of the Eclipse Public License 2.0
@@ -23,7 +23,6 @@
2323
import java.util.Optional;
2424
import java.util.function.Function;
2525
import java.util.function.Predicate;
26-
import org.eclipse.core.runtime.IStatus;
2726
import org.eclipse.e4.core.services.contributions.IContributionFactory;
2827
import org.eclipse.e4.ui.internal.workbench.PartStackUtil;
2928
import org.eclipse.e4.ui.model.application.MApplication;
@@ -62,7 +61,6 @@
6261
import org.eclipse.ui.internal.WorkbenchMessages;
6362
import org.eclipse.ui.internal.WorkbenchPage;
6463
import org.eclipse.ui.internal.WorkbenchPlugin;
65-
import org.eclipse.ui.internal.misc.StatusUtil;
6664
import org.eclipse.ui.internal.registry.ActionSetRegistry;
6765
import org.eclipse.ui.internal.registry.IActionSetDescriptor;
6866
import org.eclipse.ui.views.IViewDescriptor;
@@ -205,23 +203,6 @@ public void addActionSet(String actionSetId) {
205203
perspModel.getTags().add(ACTION_SET_TAG + actionSetId);
206204
}
207205

208-
@Override
209-
public void addFastView(String viewId) {
210-
E4Util.unsupported("addFastView: " + viewId); //$NON-NLS-1$
211-
logDeprecatedWarning(viewId);
212-
}
213-
214-
@Override
215-
public void addFastView(String viewId, float ratio) {
216-
E4Util.unsupported("addFastView: " + viewId); //$NON-NLS-1$
217-
logDeprecatedWarning(viewId);
218-
}
219-
220-
private void logDeprecatedWarning(String viewId) {
221-
String message = viewId + ": Deprecated relationship \"fast\" should be converted to \"stack\"."; //$NON-NLS-1$
222-
WorkbenchPlugin.log(message, StatusUtil.newStatus(IStatus.WARNING, message, null));
223-
}
224-
225206
@Override
226207
public void addNewWizardShortcut(String id) {
227208
perspModel.getTags().add(NEW_WIZARD_TAG + id);

0 commit comments

Comments
 (0)