Skip to content

Commit 43fc93f

Browse files
committed
Ensure legal code mining types
1 parent 4df0397 commit 43fc93f

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

bundles/org.eclipse.jface.text/src/org/eclipse/jface/internal/text/codemining/CodeMiningManager.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -280,6 +280,8 @@ private void renderCodeMinings(Map<Position, List<ICodeMining>> groups, ISourceV
280280
mode= CodeMiningMode.HeaderLine;
281281
} else if (CodeMiningMode.FooterLine.codeMiningType.isInstance(first)) {
282282
mode= CodeMiningMode.FooterLine;
283+
} else {
284+
throw new IllegalStateException("Unexpected code mining type: " + first.getClass()); //$NON-NLS-1$
283285
}
284286
}
285287

examples/org.eclipse.jface.text.examples/src/org/eclipse/jface/text/examples/codemining/MultilineCodeMiningProvider.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,9 +19,9 @@
1919
import org.eclipse.jface.text.IDocument;
2020
import org.eclipse.jface.text.ITextViewer;
2121
import org.eclipse.jface.text.Position;
22-
import org.eclipse.jface.text.codemining.AbstractCodeMining;
2322
import org.eclipse.jface.text.codemining.AbstractCodeMiningProvider;
2423
import org.eclipse.jface.text.codemining.ICodeMining;
24+
import org.eclipse.jface.text.codemining.LineContentCodeMining;
2525
import org.eclipse.jface.text.codemining.LineHeaderCodeMining;
2626

2727
public class MultilineCodeMiningProvider extends AbstractCodeMiningProvider {
@@ -35,7 +35,7 @@ public CompletableFuture<List<? extends ICodeMining>> provideCodeMinings(ITextVi
3535
int index = 0;
3636
while ((index = document.get().indexOf(multiLineText, index)) != -1) {
3737
index += multiLineText.length();
38-
res.add(new AbstractCodeMining(new Position(index, 1), this, null) {
38+
res.add(new LineContentCodeMining(new Position(index, 1), this, null) {
3939
@Override
4040
public String getLabel() {
4141
return "multiline first part in same line";

0 commit comments

Comments
 (0)