Fix JUnit 5 migration issues in test files

This commit fixes test failures introduced during the JUnit 5 migration
in PR #3410.

Changes in FilteringAsyncContentAssistTests.java:
- Changed import from org.junit.Ignore to org.junit.jupiter.api.Disabled
- Replaced @ignore annotation with @disabled annotation and added
  reason message to properly skip the test
- The test was failing because JUnit 5 does not recognize JUnit 4's
  @ignore annotation, causing a disabled test to run and fail

Changes in ResourceInitialSelectionTest.java:
- Migrated from JUnit 4 to JUnit 5 (file was missed in initial migration)
- Updated imports:
  - org.junit.Assert → org.junit.jupiter.api.Assertions
  - org.junit.Before → org.junit.jupiter.api.BeforeEach
  - org.junit.After → org.junit.jupiter.api.AfterEach
- Changed annotations: @before → @beforeeach, @after → @AfterEach
- Fixed assertion parameter order for JUnit 5 (message parameter moved
  from first to last position)
- All 13 tests now pass successfully

Test Results:
- FilteringAsyncContentAssistTests: 7 tests run, 0 failures, 1 properly skipped
- ResourceInitialSelectionTest: 13 tests run, 0 failures, 0 errors

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <[email protected]>

Author: vogella

tests/org.eclipse.jface.text.tests/src/org/eclipse/jface/text/tests/contentassist/FilteringAsyncContentAssistTests.java

@@ -24,7 +24,7 @@
 
 import org.junit.jupiter.api.AfterEach;
 import org.junit.jupiter.api.BeforeEach;
-import org.junit.Ignore;
+import org.junit.jupiter.api.Disabled;
 import org.junit.jupiter.api.Test;
 
 import org.eclipse.swt.SWT;
@@ -288,7 +288,8 @@ public void testCA_WithFirstDelayedThenImmediateProposals() throws Exception {
 	 *
 	 * @throws Exception exception
 	 */
-	@Test @Ignore
+	@Test
+	@Disabled("Bug: filtering only applied after all CA processors have completed")
 	public void testFastCompletionsNotFilteredUntilLongComplitionsCalculated() throws Exception {
 		IDocument document = viewer.getDocument();
 

tests/org.eclipse.ui.tests/Eclipse UI Tests/org/eclipse/ui/tests/dialogs/ResourceInitialSelectionTest.java

@@ -14,9 +14,9 @@
 package org.eclipse.ui.tests.dialogs;
 
 import static java.util.Arrays.asList;
-import static org.junit.Assert.assertEquals;
-import static org.junit.Assert.assertFalse;
-import static org.junit.Assert.assertTrue;
+import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertFalse;
+import static org.junit.jupiter.api.Assertions.assertTrue;
 
 import java.util.Arrays;
 import java.util.HashMap;
@@ -41,9 +41,9 @@
 import org.eclipse.ui.dialogs.FilteredResourcesSelectionDialog;
 import org.eclipse.ui.internal.decorators.DecoratorManager;
 import org.eclipse.ui.tests.harness.util.DisplayHelper;
-import org.junit.After;
-import org.junit.Before;
-import org.junit.Test;
+import org.junit.jupiter.api.AfterEach;
+import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.Test;
 
 /**
  * Tests that FilteredResourcesSelectionDialog selects its initial selection
@@ -64,7 +64,7 @@ public class ResourceInitialSelectionTest {
 	private IProject project;
 
 
-	@Before
+	@BeforeEach
 	public void doSetUp() throws Exception {
 		FILES.clear();
 		createProject();
@@ -84,7 +84,7 @@ public void testSingleSelectionAndNoInitialSelectionWithInitialPattern() {
 
 		List<Object> selected = getSelectedItems(dialog);
 
-		assertFalse("One file should be selected by default", selected.isEmpty());
+		assertFalse(selected.isEmpty(), "One file should be selected by default");
 	}
 
 	/**
@@ -102,7 +102,7 @@ public void testSingleSelectionAndOneInitialSelectionWithInitialPattern() {
 
 		List<Object> selected = getSelectedItems(dialog);
 
-		assertEquals("One file should be selected by default", asList(FILES.get("foo.txt")), selected);
+		assertEquals(asList(FILES.get("foo.txt")), selected, "One file should be selected by default");
 	}
 
 	/**
@@ -121,7 +121,7 @@ public void testSingleSelectionAndOneInitialNonExistingSelectionWithInitialPatte
 
 		List<Object> selected = getSelectedItems(dialog);
 
-		assertTrue("No file should be selected by default", selected.isEmpty());
+		assertTrue(selected.isEmpty(), "No file should be selected by default");
 	}
 
 	/**
@@ -138,7 +138,7 @@ public void testSingleSelectionAndOneInitialSelectionWithoutInitialPattern() {
 
 		List<Object> selected = getSelectedItems(dialog);
 
-		assertTrue("No file should be selected by default", selected.isEmpty());
+		assertTrue(selected.isEmpty(), "No file should be selected by default");
 	}
 
 	/**
@@ -157,7 +157,7 @@ public void testSingleSelectionAndOneFilteredSelection() {
 
 		List<Object> selected = getSelectedItems(dialog);
 
-		assertTrue("No file should be selected by default", selected.isEmpty());
+		assertTrue(selected.isEmpty(), "No file should be selected by default");
 	}
 
 	/**
@@ -176,7 +176,7 @@ public void testSingleSelectionAndTwoInitialSelectionsWithInitialPattern() {
 
 		List<Object> selected = getSelectedItems(dialog);
 
-		assertEquals("The first file should be selected by default", asList(FILES.get("foo.txt")), selected);
+		assertEquals(asList(FILES.get("foo.txt")), selected, "The first file should be selected by default");
 	}
 
 	/**
@@ -194,7 +194,7 @@ public void testMultiSelectionAndNoInitialSelectionWithInitialPattern() {
 
 		List<Object> selected = getSelectedItems(dialog);
 
-		assertFalse("One file should be selected by default", selected.isEmpty());
+		assertFalse(selected.isEmpty(), "One file should be selected by default");
 	}
 
 	/**
@@ -213,7 +213,7 @@ public void testMultiSelectionAndOneInitialSelectionWithInitialPattern() {
 
 		List<Object> selected = getSelectedItems(dialog);
 
-		assertEquals("One file should be selected by default", asList(FILES.get("foo.txt")), selected);
+		assertEquals(asList(FILES.get("foo.txt")), selected, "One file should be selected by default");
 	}
 
 	/**
@@ -230,7 +230,7 @@ public void testMultiSelectionAndOneInitialSelectionWithoutInitialPattern() {
 
 		List<Object> selected = getSelectedItems(dialog);
 
-		assertTrue("No file should be selected by default", selected.isEmpty());
+		assertTrue(selected.isEmpty(), "No file should be selected by default");
 	}
 
 	/**
@@ -249,7 +249,7 @@ public void testMultiSelectionAndTwoInitialNonExistingSelectionWithInitialPatter
 
 		List<Object> selected = getSelectedItems(dialog);
 
-		assertTrue("No file should be selected by default", selected.isEmpty());
+		assertTrue(selected.isEmpty(), "No file should be selected by default");
 	}
 
 	/**
@@ -270,7 +270,7 @@ public void testMultiSelectionAndSomeInitialNonExistingSelectionWithInitialPatte
 		Set<IFile> expectedSelection = new HashSet<>(asList(FILES.get("bar.txt"), FILES.get("foofoo")));
 		boolean allInitialElementsAreSelected = expectedSelection.equals(new HashSet<>(selected));
 
-		assertTrue("Two files should be selected by default", allInitialElementsAreSelected);
+		assertTrue(allInitialElementsAreSelected, "Two files should be selected by default");
 	}
 
 	/**
@@ -292,7 +292,7 @@ public void testMultiSelectionAndTwoInitialSelectionsWithInitialPattern() {
 		boolean initialElementsAreSelected = selected.containsAll(initialSelection)
 				&& initialSelection.containsAll(selected);
 
-		assertTrue("Two files should be selected by default", initialElementsAreSelected);
+		assertTrue(initialElementsAreSelected, "Two files should be selected by default");
 	}
 
 	/**
@@ -315,7 +315,7 @@ public void testMultiSelectionAndTwoInitialFilteredSelections() {
 		boolean initialElementsAreSelected = selected.containsAll(expectedSelection)
 				&& expectedSelection.containsAll(selected);
 
-		assertTrue("Two files should be selected by default", initialElementsAreSelected);
+		assertTrue(initialElementsAreSelected, "Two files should be selected by default");
 	}
 
 	private FilteredResourcesSelectionDialog createDialog(boolean multiSelection) {
@@ -355,11 +355,11 @@ private void createProject() throws CoreException {
 
 		for (String fileName : FILE_NAMES) {
 			DisplayHelper.waitForCondition(display, 1000, () -> project.getFile(fileName).exists());
-			assertTrue("File was not created", project.getFile(fileName).exists());
+			assertTrue(project.getFile(fileName).exists(), "File was not created");
 		}
 	}
 
-	@After
+	@AfterEach
 	public void doTearDown() throws Exception {
 		if (dialog != null) {
 			dialog.close();