Window Title: Add preference to show/hide editor tooltip part

The workbench window title can currently be customized to display
workspace name, perspective name, full path and product name. The active
editor name is shown as a part of the window title but is not
customizable in the preferences page. This change makes the active
editor info customizable.

Author: pramhegde

bundles/org.eclipse.ui.ide.application/src/org/eclipse/ui/internal/ide/application/IDEWorkbenchWindowAdvisor.java

@@ -358,7 +358,8 @@ public void partInputChanged(IWorkbenchPartReference ref) {
 					|| IDEInternalPreferences.SHOW_LOCATION.equals(property)
 					|| IDEInternalPreferences.SHOW_LOCATION_NAME.equals(property)
 					|| IDEInternalPreferences.SHOW_PERSPECTIVE_IN_TITLE.equals(property)
-					|| IDEInternalPreferences.SHOW_PRODUCT_IN_TITLE.equals(property)) {
+					|| IDEInternalPreferences.SHOW_PRODUCT_IN_TITLE.equals(property)
+					|| IDEInternalPreferences.SHOW_ACTIVE_EDITOR_INFO_IN_TITLE.equals(property)) {
 				// Make sure the title is actually updated by
 				// setting last active page.
 				lastActivePage = null;
@@ -398,9 +399,11 @@ private String computeTitle() {
 		}
 
 		// active editor
-		if (currentPage != null) {
-			if (activeEditor != null) {
-				sj.add(activeEditor.getTitleToolTip());
+		if (ps.getBoolean(IDEInternalPreferences.SHOW_ACTIVE_EDITOR_INFO_IN_TITLE)) {
+			if (currentPage != null) {
+				if (activeEditor != null) {
+					sj.add(activeEditor.getTitleToolTip());
+				}
 			}
 		}
 

bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/ide/IDEInternalPreferences.java

@@ -133,6 +133,11 @@ public interface IDEInternalPreferences {
 	 */
 	String SHOW_PRODUCT_IN_TITLE = "SHOW_PRODUCT_IN_TITLE"; //$NON-NLS-1$
 
+	/**
+	 * Whether to show the active editor information in the window title.
+	 */
+	String SHOW_ACTIVE_EDITOR_INFO_IN_TITLE = "SHOW_ACTIVE_EDITOR_INFO_IN_TITLE"; //$NON-NLS-1$
+
 	/**
 	 * System explore command, used to launch file manager showing selected
 	 * resource.

bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/ide/IDEPreferenceInitializer.java

@@ -88,6 +88,7 @@ public void initializeDefaultPreferences() {
 		node.putBoolean(IDEInternalPreferences.SHOW_LOCATION_NAME, true);
 		node.putBoolean(IDEInternalPreferences.SHOW_PERSPECTIVE_IN_TITLE, false);
 		node.putBoolean(IDEInternalPreferences.SHOW_PRODUCT_IN_TITLE, true);
+		node.putBoolean(IDEInternalPreferences.SHOW_ACTIVE_EDITOR_INFO_IN_TITLE, true);
 
 		// by default, don't start hidden problems view to show decoration on
 		// it's icon. See bug 513901

bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/ide/IDEWorkbenchMessages.java

@@ -570,6 +570,7 @@ public class IDEWorkbenchMessages extends NLS {
 	public static String IDEWorkspacePreference_showLocationNameInWindowTitle;
 	public static String IDEWorkspacePreference_showPerspectiveNameInWindowTitle;
 	public static String IDEWorkspacePreference_showProductNameInWindowTitle;
+	public static String IDEWorkspacePreference_showActiveEditorInfoInWindowTitle;
 	public static String IDEWorkspacePreference_showLocationSetOnCommandLine;
 	public static String IDEWorkspacePreference_workspaceName;
 	public static String IDEWorkbenchPreference_workbenchSystemExplorer;

bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/ide/dialogs/IDEWorkspacePreferencePage.java

@@ -93,6 +93,8 @@ public class IDEWorkspacePreferencePage extends PreferencePage implements IWorkb
 
 	private Button showProductNameInTitle;
 
+	private Button showActiveEditorInfoInTitle;
+
 	private Button autoRefreshButton;
 
 	private Button lightweightRefreshButton;
@@ -260,6 +262,7 @@ private void createWorkspaceLocationGroup(Composite composite) {
 		boolean isShowPerspective = getIDEPreferenceStore()
 				.getBoolean(IDEInternalPreferences.SHOW_PERSPECTIVE_IN_TITLE);
 		boolean isShowProduct = getIDEPreferenceStore().getBoolean(IDEInternalPreferences.SHOW_PRODUCT_IN_TITLE);
+		boolean isShowActiveEditorInfo = getIDEPreferenceStore().getBoolean(IDEInternalPreferences.SHOW_ACTIVE_EDITOR_INFO_IN_TITLE);
 
 		Composite groupComposite = new Composite(composite, SWT.LEFT);
 		GridDataFactory.fillDefaults().grab(true, false).applyTo(groupComposite);
@@ -314,6 +317,10 @@ private void createWorkspaceLocationGroup(Composite composite) {
 		showProductNameInTitle.setText(IDEWorkbenchMessages.IDEWorkspacePreference_showProductNameInWindowTitle);
 		showProductNameInTitle.setSelection(isShowProduct);
 
+		showActiveEditorInfoInTitle = new Button(grpWindowTitle, SWT.CHECK);
+		showActiveEditorInfoInTitle.setText(IDEWorkbenchMessages.IDEWorkspacePreference_showActiveEditorInfoInWindowTitle);
+		showActiveEditorInfoInTitle.setSelection(isShowActiveEditorInfo);
+
 		// disable location component if -showlocation forced
 		if (showLocationIsSetOnCommandLine) {
 			Stream.of(showLocationPathInTitle, workspacePath).forEach(c -> {
@@ -528,9 +535,12 @@ protected void performDefaults() {
 		boolean showLocationName = store.getDefaultBoolean(IDEInternalPreferences.SHOW_LOCATION_NAME);
 		boolean showPerspectiveName = store.getDefaultBoolean(IDEInternalPreferences.SHOW_PERSPECTIVE_IN_TITLE);
 		boolean showProductName = store.getDefaultBoolean(IDEInternalPreferences.SHOW_PRODUCT_IN_TITLE);
+		boolean showActiveEditorInfo = store.getDefaultBoolean(IDEInternalPreferences.SHOW_ACTIVE_EDITOR_INFO_IN_TITLE);
 		showLocationNameInTitle.setSelection(showLocationName);
 		showPerspectiveNameInTitle.setSelection(showPerspectiveName);
 		showProductNameInTitle.setSelection(showProductName);
+		this.showActiveEditorInfoInTitle.setSelection(showActiveEditorInfo);
+
 		workspaceName.loadDefault();
 
 		boolean closeUnrelatedProj = store.getDefaultBoolean(IDEInternalPreferences.CLOSE_UNRELATED_PROJECTS);
@@ -594,6 +604,7 @@ public boolean performOk() {
 		store.setValue(IDEInternalPreferences.SHOW_LOCATION_NAME, showLocationNameInTitle.getSelection());
 		store.setValue(IDEInternalPreferences.SHOW_PERSPECTIVE_IN_TITLE, showPerspectiveNameInTitle.getSelection());
 		store.setValue(IDEInternalPreferences.SHOW_PRODUCT_IN_TITLE, showProductNameInTitle.getSelection());
+		store.setValue(IDEInternalPreferences.SHOW_ACTIVE_EDITOR_INFO_IN_TITLE, showActiveEditorInfoInTitle.getSelection());
 
 		workspaceName.store();
 

bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/ide/messages.properties

@@ -547,6 +547,7 @@ IDEWorkspacePreference_showLocationInWindowTitle_lockedByCommandLine=This settin
 IDEWorkspacePreference_showLocationNameInWindowTitle=Show workspace nam&e:
 IDEWorkspacePreference_showPerspectiveNameInWindowTitle=Show perspec&tive name
 IDEWorkspacePreference_showProductNameInWindowTitle=Show product name
+IDEWorkspacePreference_showActiveEditorInfoInWindowTitle=Show active editor name
 IDEWorkspacePreference_showLocationSetOnCommandLine=Cannot modify, instance launched with -showLocation
 IDEWorkspacePreference_workspaceName=Wor&kspace name:
 IDEWorkbenchPreference_workbenchSystemExplorer=Command for launching system e&xplorer: