Skip to content

Commit 53d57fa

Browse files
committed
Restore ability to filter views by category
The ability to sort by categories was previously possible, but broke as part of 7275893. This seems to be unintentional, given that the linked bug [1] is about exposing the FilteredTree and likely a result of streamlining the implementation. [1] https://bugs.eclipse.org/bugs/show_bug.cgi?id=74795
1 parent 98ff2aa commit 53d57fa

File tree

3 files changed

+11
-3
lines changed

3 files changed

+11
-3
lines changed

bundles/org.eclipse.e4.ui.workbench.swt/META-INF/MANIFEST.MF

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
Manifest-Version: 1.0
22
Bundle-ManifestVersion: 2
33
Bundle-SymbolicName: org.eclipse.e4.ui.workbench.swt;singleton:=true
4-
Bundle-Version: 0.17.600.qualifier
4+
Bundle-Version: 0.17.700.qualifier
55
Bundle-Name: %pluginName
66
Bundle-Vendor: %providerName
77
Bundle-Localization: plugin

bundles/org.eclipse.e4.ui.workbench.swt/src/org/eclipse/e4/ui/workbench/swt/internal/copy/ViewPatternFilter.java

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/*******************************************************************************
2-
* Copyright (c) 2005, 2019 IBM Corporation and others.
2+
* Copyright (c) 2005, 2024 IBM Corporation and others.
33
*
44
* This program and the accompanying materials
55
* are made available under the terms of the Eclipse Public License 2.0
@@ -54,6 +54,10 @@ protected boolean isLeafMatch(Viewer viewer, Object element) {
5454
if (wordMatches(text)) {
5555
return true;
5656
}
57+
text = LocalizationHelper.getLocalized(desc.getCategory(), desc, context);
58+
if (wordMatches(text)) {
59+
return true;
60+
}
5761
}
5862

5963
return false;

bundles/org.eclipse.ui.workbench/eclipseui/org/eclipse/ui/internal/dialogs/ViewPatternFilter.java

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/*******************************************************************************
2-
* Copyright (c) 2005, 2014 IBM Corporation and others.
2+
* Copyright (c) 2005, 2024 IBM Corporation and others.
33
*
44
* This program and the accompanying materials
55
* are made available under the terms of the Eclipse Public License 2.0
@@ -45,6 +45,10 @@ protected boolean isLeafMatch(Viewer viewer, Object element) {
4545
if (wordMatches(text)) {
4646
return true;
4747
}
48+
text = LocalizationHelper.getLocalized(desc.getCategory(), desc);
49+
if (wordMatches(text)) {
50+
return true;
51+
}
4852
}
4953

5054
return false;

0 commit comments

Comments
 (0)